-
Notifications
You must be signed in to change notification settings - Fork 0
Sync mode reloaded #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sync mode reloaded #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f57b1c.
…to the postgres operator
eberlep
added a commit
that referenced
this pull request
Jun 28, 2024
* Bump controller-runtime * Fix metricsserver BindAddress * ... * Use same keys for logging in both reconcilers * Use common ns key in operatormanager as well * Add keys in lbmanager as well * Use both keys * Revert "Use both keys" This reverts commit d66c243. * Pass along logger * key naming * Logging * Logging * Logging * Logging * Logging * Logging * Logging * Logging * Logging * Set RequeueAfter * Logging * Logging * Logging * Logging * Logging * Add delay for requeueing * Add privileged label for initial development * operator-update step 1: bump version * operator update step 2: make svc-postgres-operator-yaml * operator update step 3: check config * operator update: update securityContext * Update YAML * Update YAML * Update securityContext of initDBJob * Add TODO * Add securityContext to etcd * Add runAsUser * Disable readonly filesystem * Update backup-restore-sidecar (and etcd) * Update etcd configMap * Revert "Set RequeueAfter" This reverts commit bdd9df0. * #88 Use default serviceAccount * Update existing namespaces with new label * Rename, logging and cleanup * (Temporarily) removing call to patroni for testing * Update to latest v0.16.x bugfix release * Add option for patroni failsafe mode (for e.g. when using K8s as DCS) * Change name again (fix for old cert-manager versions) * Revert "Change name again (fix for old cert-manager versions)" This reverts commit 9a5e7d6. * Set to nil when not needed (so it will actually be removed from the CR) * Sync mode reloaded (#572) * Check patronic config and only update if neccessary * Refactoring * ... * Refactoring * Fix linter warnings * Fix linter warning * Delay requeue by 10 secs * Check before updating standby configs as well * Improve logging * Improve logging * Improve logging * Fix check for SynchronousNodesAdditional * Fix comparison, improve logging * Additional nil check... * Test different execution order for primaries and standbies * Revert "Test different execution order for primaries and standbies" This reverts commit 3f57b1c. * Logging * Refactoring * Make requeue duration configurable * Rename variable * Add additional check (but only log the result for now) * Only requeue when REST call was successful * Fix linter errors * Set to nil when not needed (so it will actually be removed from the CR) * Only set the params required for sync replication and leave the rest to the postgres operator * Remove unneccessary code * logging * Remove unused code * Fix logic * Update logic * Revert "Remove unused code" This reverts commit 7e525ec. * Revert "Remove unneccessary code" This reverts commit 00cc28f. * Update previously reverted code * Set all values when paching * Logging * Back to status quo: set the whole config * typo * Logging * Remove TODOs after review * Simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #423 but modified to only set the parameters required for sync replication. The rest should be handled by the postgres operator.