Skip to content

Logging best practises #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Logging best practises #585

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e2f338e
Update default password hashing algorithm
eberlep Aug 2, 2024
fc971ff
Tell the linter that this is not a password
eberlep Aug 2, 2024
e266016
Merge branch 'main' into update_pw_hashing_algorithm
eberlep Oct 24, 2024
30f1b29
Merge branch 'main' into update_pw_hashing_algorithm
eberlep Oct 31, 2024
daadf2f
Sort alphabetically
eberlep Oct 31, 2024
b167153
Add additional logging params
eberlep Oct 31, 2024
6b81ae6
Merge remote-tracking branch 'origin' into logging_best_practises
eberlep Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions api/v1/postgres_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ const (
defaultPostgresParamValueWalKeepSize = "1GB"
defaultPostgresParamValuePGStatStatementsMax = "500"
defaultPostgresParamValuePasswordEncryption = "scram-sha-256" // nolint
defaultPostgresParamValueLogMinErrorStatement = "WARNING"
defaultPostgresParamValueLogErrorVerbosity = "VERBOSE"
defaultPostgresParamValueLogLinePrefix = "%m [%p]: [%l-1] db=%d,user=%u,app=%a,client=%h "

// PostgresAutoAssignedIPNamePrefix a prefix to add to the generated random name
PostgresAutoAssignedIPNamePrefix = "pgaas-autoassign-"
Expand Down Expand Up @@ -959,12 +962,16 @@ func enableAuditLogs(parameters map[string]string) {
// setDefaultPostgresParams configures default keepalive values
func setDefaultPostgresParams(parameters map[string]string, version string) {
// set default parameters
parameters["tcp_keepalives_idle"] = defaultPostgresParamValueTCPKeepAlivesIdle
parameters["tcp_keepalives_interval"] = defaultPostgresParamValueTCPKeepAlivesInterval
parameters["log_error_verbosity"] = defaultPostgresParamValueLogErrorVerbosity
parameters["log_file_mode"] = defaultPostgresParamValueLogFileMode

parameters["ssl_prefer_server_ciphers"] = defaultPostgresParamValueSSLPreferServerCiphers
parameters["log_line_prefix"] = defaultPostgresParamValueLogLinePrefix
parameters["log_min_error_statement"] = defaultPostgresParamValueLogMinErrorStatement
parameters["password_encryption"] = defaultPostgresParamValuePasswordEncryption
parameters["pg_stat_statements.max"] = defaultPostgresParamValuePGStatStatementsMax
parameters["ssl_ciphers"] = defaultPostgresParamValueSSLCiphers
parameters["ssl_prefer_server_ciphers"] = defaultPostgresParamValueSSLPreferServerCiphers
parameters["tcp_keepalives_idle"] = defaultPostgresParamValueTCPKeepAlivesIdle
parameters["tcp_keepalives_interval"] = defaultPostgresParamValueTCPKeepAlivesInterval

// set version specific parameters
v, err := strconv.Atoi(version)
Expand All @@ -981,10 +988,6 @@ func setDefaultPostgresParams(parameters map[string]string, version string) {
} else {
parameters["wal_keep_segments"] = defaultPostgresParamValueWalKeepSegments
}

parameters["pg_stat_statements.max"] = defaultPostgresParamValuePGStatStatementsMax

parameters["password_encryption"] = defaultPostgresParamValuePasswordEncryption
}

// setPostgresParams add the provided params to the parameter map (but ignore params that are blocked)
Expand Down
Loading