Code Quality: Added sponsor flyout for sideload versions #17240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new sponsor prompt for sideload environments, refactors the existing review prompt logic, and updates resource keys and settings to support both prompts.
- Added a Sponsor TeachingTip to MainPage.xaml, with new
ShowSponsorPromptbinding and commands. - Renamed and consolidated resource keys for review and sponsor UI strings.
- Updated the ViewModel and settings service to track prompt clicks and adjusted launch-count logic.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Files.App/Views/MainPage.xaml | Added sponsor TeachingTip and updated the review prompt title |
| src/Files.App/ViewModels/MainPageViewModel.cs | Introduced ShowSponsorPrompt, commands, and renamed review flags |
| src/Files.App/Strings/en-US/Resources.resw | Renamed ReviewFilesTitle to Hello, added sponsor strings |
| src/Files.App/Services/Settings/ApplicationSettingsService.cs | Renamed ClickedToReviewApp, added HasClickedSponsorPrompt |
| src/Files.App/Data/Contracts/IApplicationSettingsService.cs | Updated interface for renamed and new prompt settings |
| src/Files.App/Helpers/Application/AppLifecycleHelper.cs | Changed launch-count assignment to use TryParse |
| src/Files.App/Constants.cs | Updated SupportUsUrl for the sponsor link |
Comments suppressed due to low confidence (2)
src/Files.App/Views/MainPage.xaml:371
- [nitpick] Using the resource key
Hellofor both review and sponsor titles is ambiguous. Consider restoring a descriptive key likeReviewFilesTitleand adding a newSponsorTitleresource.
Title="{helpers:ResourceString Name=Hello}"
src/Files.App/Helpers/Application/AppLifecycleHelper.cs:65
- [nitpick] Parsing the launch count by converting to string adds unnecessary overhead. Consider using
launchCount is long l ? l + 1 : 1for direct pattern matching.
TotalLaunchCount = long.TryParse(launchCount?.ToString(), out var v) ? v + 1 : 1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.