Skip to content

Code Quality: Defer CurrentSelectedMode assignment in OmnibarMode_Loaded #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Files.App.Controls/Omnibar/OmnibarMode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ private void OmnibarMode_Loaded(object sender, RoutedEventArgs e)
{
// Set this mode as the current mode if it is the default mode
if (IsDefault && _ownerRef is not null && _ownerRef.TryGetTarget(out var owner))
owner.CurrentSelectedMode = this;
{
DispatcherQueue.TryEnqueue(() =>
{
owner.CurrentSelectedMode = this;
});
}
}

public void SetOwner(Omnibar owner)
Expand Down
Loading