Code Quality: Use temporary files to extract zip entries

[seer-by-sentry]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes FILES-APP-1Z5

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Opened Files with a large zip archive.
2. Extracted the zip archive.
3. Verified that the extraction completed successfully without an OutOfMemoryException.
4. Monitored memory usage during extraction to ensure it remained within acceptable limits.

Fixes FILES-APP-1Z5. The issue was that: Zip file operations load entire files/archives into memory, exhausting RAM and causing OutOfMemoryException.

• Extracts zip entries to temporary files instead of memory streams to avoid memory issues with large files.
• Uses FileOptions.DeleteOnClose to automatically delete the temporary file when the stream is closed.
• Adds error handling to delete the temporary file if extraction fails.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 852921

Not quite right? Click here to continue debugging with Seer.

[Copilot]

Pull Request Overview

This PR addresses a critical memory issue in zip file operations by replacing in-memory extraction with temporary file-based extraction. The change prevents OutOfMemoryException when working with large zip archives by avoiding loading entire files into RAM.

• Replaces MemoryStream usage with temporary file streams for zip entry extraction
• Implements automatic cleanup of temporary files using FileOptions.DeleteOnClose and explicit cleanup in error scenarios
• Applies the fix consistently across all zip operation methods (OpenAsync, OpenReadAsync, OpenSequentialReadAsync, CopyAsync, RenameAsync, DeleteAsync)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Calling fileStream.Dispose() in the DisposeCallback is redundant and potentially harmful. The NonSeekableRandomAccessStreamForRead should handle disposal of its underlying stream, and calling Dispose() twice could cause ObjectDisposedException.

Suggested change

fileStream.Dispose();

[Copilot]

Calling fileStream.Dispose() in the DisposeCallback is redundant and potentially harmful. The NonSeekableRandomAccessStreamForRead should handle disposal of its underlying stream, and calling Dispose() twice could cause ObjectDisposedException.

Suggested change

fileStream.Dispose();

[Copilot]

Calling fileStream.Dispose() in the DisposeCallback is redundant and potentially harmful. The NonSeekableRandomAccessStreamForRead should handle disposal of its underlying stream, and calling Dispose() twice could cause ObjectDisposedException.

Suggested change

fileStream.Dispose();

[Copilot]

Using FileOptions.DeleteOnClose with a 'using' statement creates a race condition. The file will be deleted when the FileStream is disposed at the end of the using block, but the NonSeekableRandomAccessStreamForRead may still need access to it after this method returns.

[Copilot]

The empty catch block silently swallows all exceptions when trying to delete the temporary file. Consider logging the exception or at least catching specific exceptions like FileNotFoundException or UnauthorizedAccessException to avoid hiding unexpected errors.

Suggested change

	try { IO.File.Delete(tempFile); } catch { }
	try { IO.File.Delete(tempFile); } catch (Exception ex) { System.Diagnostics.Debug.WriteLine($"Failed to delete temp file '{tempFile}': {ex}"); }