Code Quality: Added support for middle clicking in the new BreadcrumbBar #17476
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Aug 20, 2025
yaira2
reviewed
Aug 24, 2025
| @@ -10,7 +10,7 @@ public partial class BreadcrumbBarItem | |||
| { | |||
| private void ItemContentButton_Click(object sender, RoutedEventArgs e) | |||
| { | |||
| OnItemClicked(); | |||
| //OnItemClicked(); | |||
There was a problem hiding this comment.
Is this supposed to be commented out?
There was a problem hiding this comment.
Thought it would be better than removing the event handler to let poeple notice that this is already handled. Should we remove?
There was a problem hiding this comment.
If it's already handled, it should be removed.
yaira2
reviewed
Aug 24, 2025
| @@ -279,7 +279,8 @@ private async void BreadcrumbBar_ItemClicked(Controls.BreadcrumbBar sender, Cont | |||
| ViewModel.PathComponents[args.Index].Path is not { } path) | |||
| return; | |||
|
|
|||
| await ViewModel.HandleFolderNavigationAsync(path); | |||
| var pointerUpdateKind = args.PointerRoutedEventArgs.GetCurrentPoint(null).Properties.PointerUpdateKind; | |||
| await ViewModel.HandleFolderNavigationAsync(path, pointerUpdateKind is PointerUpdateKind.MiddleButtonReleased); | |||
There was a problem hiding this comment.
Instead of passing PointerUpdateKind.MiddleButtonReleased directly, I think we can make the code easier to read if we add another variable like this var openInNewTab = PointerUpdateKind.MiddleButtonReleased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes