Feature: Added support for cloning GitLab repository URLs #17509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
force-pushed
the
sg/gitlab-cloning-support
branch
from
427b481 to
e4e6615
Compare
yaira2
changed the title
yaira2
added
the
ready to merge
|
Will this work with other links such as git://git.w1.fi/hostap.git ? |
Not currently, but it should be simple enough to update the regex to support any link ending with git. |
Extended the repository URL regex to accept both github.com and gitlab.com
yaira2
force-pushed
the
sg/gitlab-cloning-support
branch
from
aec16f5 to
e767230
Compare
yaira2
force-pushed
the
sg/gitlab-cloning-support
branch
from
e767230 to
c1a1fe2
Compare
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes #17385
Steps used to test these changes
Method 1: Using Command Palette
Opened the Files app and navigated to an available folder.
Pressed Ctrl + Shift + P to open the command palette.
Entered Clone and selected Clone Git Repository.
Pasted https://gitlab.com/es-de/emulationstation-de.git in the repository URL text box.
Verified that the Clone button was enabled.
Clicked the Clone button, and the repository was successfully cloned to the local folder.
Method 2: Using Drag & Drop
Opened the Files app and navigated to an available folder.
Dragged and dropped the repository link (https://gitlab.com/es-de/emulationstation-de.git) into the Files window.
Verified that the Clone button was enabled.
Clicked the Clone button, and the repository was successfully cloned to the local folder.
Note:
Repeated the above steps with https://github.com/files-community/Files.git to ensure there was no impact on cloning existing GitHub URLs.