Skip to content

Use form.getState() directly instead of using subscriptions. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use form.getState() directly instead of using subscriptions. #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/decorator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,9 @@ const createDecorator = (
// Save original submit function
const originalSubmit = form.submit

// Subscribe to errors, and keep a local copy of them
let state: { errors?: Object, submitErrors?: Object } = {}
const unsubscribe = form.subscribe(
nextState => {
state = nextState
},
{ errors: true, submitErrors: true }
)

// What to do after submit
const afterSubmit = () => {
const { errors, submitErrors } = state
const { errors, submitErrors } = form.getState()
if (errors && Object.keys(errors).length) {
focusOnFirstError(errors)
} else if (submitErrors && Object.keys(submitErrors).length) {
Expand All @@ -58,7 +49,6 @@ const createDecorator = (
}

return () => {
unsubscribe()
form.submit = originalSubmit
}
}
Expand Down