refactor: service module to TS + ESM (v2)

[jescalada]

Fixes #1062.

Note that the changes in the package-lock.json are due to adding the nodemailer types. nodemailer doesn't seem to be used outside of the /src/service/emailSender.ts file which is currently unused, however it will likely be used eventually for solving #1121 (so we might as well keep it unless there's a better email library).

Removed nodemailer and nodemailer/types to reduce package bloat and prevent incompatible license problems. We can always use another email library to implement #1121 later on.

[netlify]

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name	Link
🔨 Latest commit	eef5f40
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68d6075fbc5e5b00089b45f1

[codecov]

Codecov Report

❌ Patch coverage is 73.30896% with 146 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.67%. Comparing base (32bfc70) to head (eef5f40).

Files with missing lines	Patch %	Lines
src/service/routes/push.ts	64.07%	32 Missing and 5 partials ⚠️
src/service/passport/oidc.ts	67.24%	17 Missing and 2 partials ⚠️
src/service/passport/ldaphelper.ts	27.27%	16 Missing ⚠️
src/service/passport/jwtAuthHandler.ts	70.27%	5 Missing and 6 partials ⚠️
src/service/routes/auth.ts	73.17%	10 Missing and 1 partial ⚠️
src/service/routes/repo.ts	64.51%	3 Missing and 8 partials ⚠️
src/service/routes/users.ts	64.00%	9 Missing ⚠️
src/service/passport/jwtUtils.ts	82.92%	5 Missing and 2 partials ⚠️
src/service/index.ts	91.11%	2 Missing and 2 partials ⚠️
src/service/passport/activeDirectory.ts	75.00%	2 Missing and 2 partials ⚠️
... and 9 more

❌ Your patch check has failed because the patch coverage (73.30%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   84.06%   83.67%   -0.40%     
==========================================
  Files          68       70       +2     
  Lines        2944     3002      +58     
  Branches      373      499     +126     
==========================================
+ Hits         2475     2512      +37     
+ Misses        409      395      -14     
- Partials       60       95      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jescalada]

Finally answered/fixed up all the comments here! Would love to get one last look 😃 @kriswest @06kellyjac

[kriswest]

A couple of quick comments - will try to complete a pass later on

[andypols]

@jescalada and @kriswest - nice work. Would be awesome to get this merged as want to work in this area and don't want to get in people's way.

[jescalada]

Hi @06kellyjac, just got the merge conflicts fixed so this is ready for a final look! 😃