Skip to content

Conversation

@jescalada
Copy link
Contributor

@jescalada jescalada commented Dec 3, 2025

Fixes #1291.

Related:

Ideally, we'd find a way to keep the singleBranch option (perhaps by fetching only the relevant branch on push?). Made this quick fix PR to kickstart the v2 release!

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 23776b6
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6931729a1760e70008af9f64

@jescalada jescalada requested a review from a team December 3, 2025 15:44
@github-actions github-actions bot added the fix label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.99%. Comparing base (a8224fb) to head (23776b6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
- Coverage   81.00%   80.99%   -0.01%     
==========================================
  Files          66       66              
  Lines        4500     4499       -1     
  Branches      776      776              
==========================================
- Hits         3645     3644       -1     
  Misses        840      840              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (for now)

@kriswest kriswest enabled auto-merge December 4, 2025 11:38
@kriswest kriswest merged commit 219770e into finos:main Dec 4, 2025
14 checks passed
@jescalada
Copy link
Contributor Author

jescalada commented Dec 4, 2025

@kriswest If it reassures you, I did some profiling and it seems most of the speed benefits for pushes are coming from setting depth: 1. The first is the execution for this branch, and the second is the execution before the original fix:

image

@jescalada
Copy link
Contributor Author

For the record, removing depth: 1 results in a pullRemote execution time of ~1300ms vs ~700ms when it's active. Setting singleBranch: true further speeds up execution down to ~600ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subsequent pushes to the same branch fail: Invalid revision range

2 participants