doc: fix missing iptables rul for network-for-clones.md #5316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing setup in network-for-clones.md about setup egress connectivity cannot work.
Changes
Update the
docs/snapshotting/network-for-clones.md
to be consistent withtests/framework/microvm_helpers.py
.Reason
There lacks one iptable configuration about setup egress connectivity. As shown in
firecracker/tests/framework/microvm_helpers.py
Line 190 in 7dfe276
It should add a MASQUERADE rule inside the netns. After that, the host iptable rules of source ip 10.0.0.0/30 can work. Without that, the host can only see packet of source ip (e.g., 192.168.241.1/29) from guest VM.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.