Increase testing coverage for PCI code #5346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pcie #5346 +/- ##
================================================
+ Coverage 80.59% 82.35% +1.75%
================================================
Files 265 265
Lines 30690 30640 -50
================================================
+ Hits 24736 25233 +497
+ Misses 5954 5407 -547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bchalios
force-pushed
the
cleanup_code
branch
13 times, most recently
from
874ffb1 to
f083fe6
Compare
bchalios
added
the
Status: Awaiting review
Manciukic
previously approved these changes
Aug 12, 2025
We are not really using the `as_any` and `id` members of the PciDevice trait. At the moment, only VirtIO devices and the PCI root port is implementing PciDevice and we are never iterating over the container of PCI devices. Signed-off-by: Babis Chalios <[email protected]>
Add a unit test for the logic that handles adding BARs for a device. Also, ensure that we check that the BAR index we are adding is within range before we use it to index the BARs vector. Signed-off-by: Babis Chalios <[email protected]>
Make sure that configuring the MSI-X capability in PCI configuration space works properly (configuration space is initialized as expected). Also, make sure that the implementation respects the read/write properties of the respective bits. Finally, fix logic in the code that adds capabilities to take into account properly the size of capabilities. Signed-off-by: Babis Chalios <[email protected]>
Make sure we handle correctly accessing invalid registers. Signed-off-by: Babis Chalios <[email protected]>
Make sure we detect correctly valid intents to reprogram (move) BARs. Also, make sure we correctly ignore buggy ones. Signed-off-by: Babis Chalios <[email protected]>
Add a few unit tests to check the logic that accesses PCI configuration space via the PCI Bus. Ensure that negative cases are being handled properly. Signed-off-by: Babis Chalios <[email protected]>
Also, drop some of effectively dead code that Cloud Hypervisor was using because they were not relying on KVM to handle interrupt controllers. Finally, fixup some error cases on guest reads which need to return all-ones when bad accesses happen. Signed-off-by: Babis Chalios <[email protected]>
bchalios
dismissed
Manciukic’s stale review
The merge-base changed after approval.
bchalios
added
Status: Awaiting review
roypat
approved these changes
Aug 12, 2025
ShadowCurse
reviewed
Aug 12, 2025
Manciukic
approved these changes
Aug 12, 2025
bchalios
merged commit 75eb51d
into
firecracker-microvm:feature/pcie
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add tests for PCI-related code within the
pcicrateUnit tests for PCI configuration space handling, regarding guest accesses within the configuration space and configuration of MSIx interrupts
Reason
Increase testing coverage
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.