chore: fix wrong fd_pool acquire usage #7057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
ripatel-fd
requested changes
Nov 4, 2025
Contributor
ripatel-fd
left a comment
ripatel-fd
left a comment
There was a problem hiding this comment.
Can we just introduce an acquire_safe API here instead of removing error checks?
Contributor
Author
I don't fully understand what you are proposing to do. |
two-heart
reviewed
Nov 5, 2025
calling acquire on a pool with no space left is UB and cannot be assumed to return NULL
intrigus-lgtm
force-pushed
the
intrigus/fix/more-fd_pool_acquire-ub
branch
from
8eed1bd to
736f56e
Compare
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling acquire on a pool with no space left is UB and cannot be assumed to return NULL
Fixes all the results that #7056 finds.