-
Notifications
You must be signed in to change notification settings - Fork 176
Fix point evaluation API change #4675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Conversation
|
This is a bug fix (and a critical one at that) so should go into |
|
We should also fix calling a We need something like |
|
Ideally we would want |
2df11b3 to
b95a4a0
Compare
730023c to
f94ae63
Compare
fix more test tensor tests fix
lint
f94ae63 to
af5cfcb
Compare
|
@leo-collins the recommendations from the meeting yesterday were:
I confess I got a bit confused by what we ended up deciding to do but if you agree with that please implement it here and poke me for a review when the tests are passing. I can then make a new release. |
Description
I accidentally changed the API of
Function.evaluatein #4543. This changes the shape of the output to how it was before. There were no tests looking for this before so I've added some.