Skip to content

FunctionSpace: introduce extruded_periodic attribute #4701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 82 commits into
base: main
Choose a base branch
from
Open

FunctionSpace: introduce extruded_periodic attribute #4701

wants to merge 82 commits into from

Conversation

@pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Nov 4, 2025

Description

pbrubeck and others added 30 commits September 8, 2025 15:15
@pbrubeck
Support mat_type="is"
22ea2c4
@pbrubeck
MatIS: support DirichletBC, add a test
9042f45
@pbrubeck
MatIS: Fix parallel LGMap
642d18b
@pbrubeck
MatNest + MatIS
2d06f08
@pbrubeck
More comprehensive tests
7bca3e6
@pbrubeck
Propagate sub_mat_type, fix MatNest + MatIS
d0b6469
@pbrubeck
Only set sub_mat_type on the diagonal blocks
6b7c7f1
@pbrubeck
style
f9e0bd4
@pbrubeck
Test BDDC, setCoordinates
5c715e1
@pbrubeck
Fix VectorFunctionSpace
7956efd
@stefanozampini @pbrubeck
refine BDDC customization
8248cf9
@stefanozampini @pbrubeck
fix lint
f6c4778
@stefanozampini @pbrubeck
Simplify coordinates handling of bddcpc driver
32b2c4d 
cleanup test
@stefanozampini @pbrubeck
Don't know why this fixes the mapping for me
3f33eff
@pbrubeck
test tabulate_exterior_derivative
b945f38
@stefanozampini @pbrubeck
add failing test
e4fc071
@pbrubeck
Fix vertex dofs
f701ec3
@pbrubeck
Add permutation test
baa8da5
@pbrubeck
Trivial case for get_restriction_indices
245362d
@pbrubeck
DROP BEFORE MERGE
5397bcf
@pbrubeck
mark parellel test
8979c96
@stefanozampini @pbrubeck
bddc: use callables for gradient and divergence
79314b5
@stefanozampini @pbrubeck
minor
72b782c
@pbrubeck
tabulate_exterior_derivative as MatIS
0808ccd
@pbrubeck
Fix tabulate_exterior_derivative in parallel
fb3dda7
@pbrubeck
BDDC get_divergence_mat
052bedd
@pbrubeck
Fix high-order divergence tabulation
1ec8faa
@pbrubeck
Cleanup
671261b
@pbrubeck
cleanup
6926ad1
@pbrubeck
Fix Q1
f5e1651
pbrubeck and others added 26 commits October 17, 2025 14:52
@pbrubeck
Merge branch 'main' into pbrubeck/matis
c433530
@pbrubeck
Fix test
cf1bd88
@pbrubeck
Merge branch 'main' into pbrubeck/matis
7978e8a
@pbrubeck
Drop unrelated change
74a52ec
@pbrubeck
Update pyop2/types/mat.py
4c50572
@pbrubeck
Apply suggestions from code review
cb83725
@pbrubeck
Update firedrake/matrix_free/operators.py
46e3354
@pbrubeck
Merge branch 'main' into pbrubeck/matis
81ec989
@pbrubeck
topological_dimension
a0e01cd
@pbrubeck @JHopeCollins
Apply suggestions from code review
53b22e1 
Co-authored-by: Josh Hope-Collins <[email protected]>
@pbrubeck
Merge branch 'main' into pbrubeck/matis
810e595
@pbrubeck
Test BDDC for H(curl) and H(div)
09dec97
@pbrubeck
Update firedrake/preconditioners/bddc.py
8939fc4
@pbrubeck
docs
31c80d8
@pbrubeck
implement is_lagrange
7c31da6
@pbrubeck
remove unrelated change
20b49dc
@pbrubeck
test for correctness
f356c0f
@pbrubeck
test mesh independence
dde83a8
@pbrubeck
cleanup
a87093e
@pbrubeck
cleanup
b10e62a
@pbrubeck
Apply suggestions from code review
a2d8f30
@pbrubeck
Merge branch 'main' into pbrubeck/matis
af3b325
@pbrubeck
add more tests
73cdcc2
@pbrubeck
fix complex
4800570
@pbrubeck
Extruded periodic
c88b5e4
@pbrubeck
FunctionSpace: introduce extruded_periodic attribute
39a9395
connorjward
connorjward reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we should be doing this. Extrusion is an attribute of the mesh, not the function space. The change is quite invasive for a one line improvement.

@pbrubeck
Copy link
Contributor Author

pbrubeck commented Nov 4, 2025

I don't think that we should be doing this. Extrusion is an attribute of the mesh, not the function space. The change is quite invasive for a one line improvement.

Should we remove the already existing attribute FunctionSpace.extruded instead? I am just adding it mainly because I originally had V.extruded, but did not find V.extruded_periodic.

@connorjward
Copy link
Contributor

connorjward commented Nov 4, 2025

I don't think that we should be doing this. Extrusion is an attribute of the mesh, not the function space. The change is quite invasive for a one line improvement.

Should we remove the already existing attribute FunctionSpace.extruded instead? I am just adding it mainly because I originally had V.extruded, but did not find V.extruded_periodic.

I think I would be in favour of that, but that should be discussed more widely as it's a breaking API change.

Base automatically changed from pbrubeck/matis to main November 4, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjward connorjward connorjward left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbrubeck @connorjward @stefanozampini