First run I/O #664
Draft
First run I/O #664
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
reviewed
Nov 7, 2025
| Args: | ||
| t (float): the start time of the run | ||
| tmax (float): the end time of the run | ||
| pick_up: (bool): specify whether to pick_up from a previous run |
Contributor
There was a problem hiding this comment.
Missing from the docstring
gusto/timestepping/timestepper.py
Outdated
| logger.debug(f'{field_name}, min: {min_val}, max: {max_val}') | ||
|
|
||
| def run(self, t, tmax, pick_up=False): | ||
| def run(self, t, tmax, pick_up=False, first_run=True): |
Contributor
There was a problem hiding this comment.
I know it's not really my place to review Gusto code but I feel this might be more elegant if this were called init_io or similar. Or you could even set this attribute inside Timestepper.__init__.
Contributor
There was a problem hiding this comment.
yes, this is a nice idea @connorjward - thanks! your comments are always appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the set-up of characteristics of the I/O. It adds a
first_runflag to the time stepper'srunmethod, which isTrueuntil the components of the I/O have been set up, after which it becomesFalse. This is to facilitate solving a PDE in Gusto multiple times as part of a hybrid ML model.