Security Fix: Replace unmaintained sqlitedict (CVE-2024-35515) with diskcache in deprecated CharLMEmbeddings #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iskcache in deprecated CharLMEmbeddings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlitedicthas not been updated since late 2022 and has a high risk security vulnerability (CVE-2024-35515). WhileCharLMEmbeddingsis deprecated, removing the vulnerable dependency is still important for overall project health and security scanning. I've chosendiskcacheas the migration as it provides persistent key-value storage with features like automatic eviction, size limits, and thread/process safety, often exceeding sqlitedict's capabilities. It uses SQLite as one of its backends by default, offering a similar persistence mechanism. It also has no security vulnerabilities listed in the OSV database.