-
Notifications
You must be signed in to change notification settings - Fork 561
Feature/moe bf16 pr #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aleozlx
wants to merge
13
commits into
flashinfer-ai:main
Choose a base branch
from
aleozlx:feature/moe_bf16_pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/moe bf16 pr #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
IMA |
Collaborator
|
Hi @aleozlx can we confirm whether this IMA is a kernel issue or an integration issue? |
5 tasks
jiahanc
added a commit
that referenced
this pull request
Nov 8, 2025
<!-- .github/pull_request_template.md --> ## 📌 Description - Refactor `trtllm_fused_moe_kernel_launcher.cu` to use class structure for code cleanliness and readability - Add BF16 MOE, initial PR (#1859) from @aleozlx and @nekorobov - Add BF16 MOE autotune <!-- What does this PR do? Briefly describe the changes and why they’re needed. --> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * BF16 Mixture-of-Experts (MoE) pathway added with autotuning and public API access. * **Improvements** * Unified BF16/FP8/FP4/FP16 pathways with clearer dtype compatibility checks and corrected operator return semantics. * Routing selection now respects token-size and input packing, and diagnostics produce more descriptive error messages. * **Tests** * Expanded BF16 test coverage across routing modes, weight layouts, and token sizes. * **Chores** * Updated artifact metadata and checksums. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: jiahanc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
trtllm-gen bf16 moe
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
In the new
trtllm_bf16_moeinterface, i used*in the argument list to mark which ones should be passed by keyword only. It is a practice to make function calls less error prone when the function has a very long list of arguments. Before*are the ones commonly used, whereas the ones after are optional ones / perf tuning.