Check if options.uri is already set, seems to be an issue with retries #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anybody else had the same issue? |
|
Can you reproduce the issue and if so, how? It's better to find the core of the issue than patching it up. |
|
I can on IrisCouch - running on iriscouch, I was getting errors, put in the retry and it was failing to get the options.uri as options.path did not exist. |
|
This helped me! Was testing out what happens if I lose connection with CouchDB and it was crashing my server. With this I can get an error back instead. Thanks! Would love for this to be pulled in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with retries, to the point that it already has the options.uri and no options.path