Skip to content

support for Node.js 12 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024
Merged

support for Node.js 12 #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e40ea8
support for Node.js 12
Xmader Jun 4, 2019
b3299a8
Backward compatible
Xmader Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/response-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,15 @@ var ResponseStream = module.exports = function (options) {
});

if (this.response) {
this._headers = this.response._headers = this.response._headers || {};

// Patch to node core
this.response._headerNames = this.response._headerNames || {};
try {
this._headers = this.response.getHeaders() || {};
} catch (err) {
this._headers = this.response._headers = this.response._headers || {};

// Patch to node core
this.response._headerNames = this.response._headerNames || {};
Copy link

@lamweili lamweili Feb 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this not be in the catch, but in another try-catch?

// Patch to node core
try {
  this.response._headerNames = this.response.getHeaderNames() || {};
} catch (err) {
  this.response._headerNames = this.response._headerNames || {};  
}

Copy link

@lamweili lamweili Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been commented in PR #77 that there is no need for this suggestion.
@darrendatbui has did some testing and the original committed code works.

I rest my case.

}

//
// Proxy to emit "header" event
Expand Down