Add rds_config.deletion_protection passthrough to the Aurora cluster - #275
Open
fleet-dylan wants to merge 1 commit into
Open
Add rds_config.deletion_protection passthrough to the Aurora cluster#275fleet-dylan wants to merge 1 commit into
fleet-dylan wants to merge 1 commit into
Conversation
fleet-dylan
force-pushed
the
rds-deletion-protection
branch
from
August 8, 2026 00:22
a652990 to
5d2715c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws_rds_cluster.deletion_protectioncurrently cannot be set through the root module orbyo-vpc: the innerterraform-aws-modules/rds-auroracall does not receive it, so itsnulldefault always applies. Anyone who enables deletion protection on the cluster out-of-band then sees a permanentdeletion_protection: true -> falsediff on every plan, and an apply silently disables the protection.This adds an optional
rds_config.deletion_protection(defaultnull) in the root module andbyo-vpc, passed through to the aurora module. The default preserves current behavior exactly.Happy to regenerate READMEs / adjust module version tags to match your release process.