Example GIF and Live Example for ReorderableListView added #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example gif has been changed to match the documentation. The live example still remains unchanged and needs to be changed.
…atic/img/docs/controls/reorderablelistview/reorderablelistview-example.gif
1 task
ndonkoHenri
approved these changes
Mar 18, 2025
|
Thanks for your efforts. Can you do more hi-res screenshot please? |
For the Example GIF? Sure, I can try! |
|
Better, but there is a black border on the right and bottom. Could you please remove it? |
|
Done! |
`page.overlay` is already a list of controls. `page.overlay.controls` does not exist and was previously an error, that could've confused some beginners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example gif has been added in a separate folder within the /static/controls folder by the name of `reorderablelistview-example.gif', following the naming conventions observed with all other files in the repo. Also, the markdown code for the docs have been changed to render the newly added example gif instead.
The live example url has been updated to match the live example added in the following pull request.
This fixes the following issues: #410