#1955 - unify json entry #1959
Draft
#1955 - unify json entry #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
reviewed
Nov 5, 2025
| #[DocumentationDSL(module: Module::CORE, type: DSLType::ENTRY)] | ||
| function json_entry(string $name, array|string|null $data, ?Metadata $metadata = null) : Entry | ||
| { | ||
| if (\is_array($data)) { |
Member
There was a problem hiding this comment.
this doesn't make much sense, array can still be a regular array but not json object.
{
"id" : 1,
"name": "test"
}
In PHP is ['id' => 1, "name" => "test"]
But [{"id": 1, "name": "test"}] in php would be [["id":1, "name": "test"]] however both satisfies php is_array.
If anything I would probably do a json_encode on value when is_array
norberttech
reviewed
Nov 5, 2025
| } | ||
|
|
||
| return $this->is($entry->name()) && $entry instanceof self && type_equals($this->type, $entry->type) && (new ArrayComparison())->equals($thisValue, \is_array($entryValue) ? $entryValue : null); | ||
| return $this->is($entry->name()) && $entry instanceof self && type_equals($this->type, $entry->type) && $thisValue === $entryValue; |
Member
There was a problem hiding this comment.
something tells me this will break a lot of tests 🫢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1955
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security