Skip to content

out_exit: document new parameters for PR#8621. #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2025
Merged

out_exit: document new parameters for PR#8621. #1346

merged 4 commits into from
Oct 23, 2025

Conversation

@pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Mar 21, 2024

This adds documentation for the parameters proposed for by fluent/fluent-bit#8621.

@pwhelan
Create exit.md
6288ccc 
Signed-off-by: Phillip Whelan <[email protected]>
@pwhelan pwhelan requested review from edsiper and lecaros March 21, 2024 22:05
@pwhelan pwhelan mentioned this pull request Mar 22, 2024
Merged
7 tasks
@lecaros lecaros requested review from a team as code owners March 25, 2025 14:34
@eschabell eschabell requested a review from esmerel October 22, 2025 15:26
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Oct 22, 2025
@eschabell
Copy link
Collaborator

@esmerel can you review so I can merge this docs PR, the corresponding code PR is merged already.

Note I think this is missing the entry for the new output plugin file in the Summary.md to make the docs page?

@eschabell eschabell self-assigned this Oct 22, 2025
esmerel
esmerel requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated for style and consistency, but the keys need to be made consistent.

@esmerel
Copy link
Contributor

esmerel commented Oct 22, 2025

@esmerel can you review so I can merge this docs PR, the corresponding code PR is merged already.

Note I think this is missing the entry for the new output plugin file in the Summary.md to make the docs page?

The summary.md change should also be made, yes!

@esmerel
Update SUMMARY.md
04d959a 
Hopefully I'm adding the new exit output to the summary file to the PR where the exit docs are being added.


Signed-off-by: Lynette  Miles <[email protected]>
@esmerel
Copy link
Contributor

esmerel commented Oct 22, 2025

@esmerel can you review so I can merge this docs PR, the corresponding code PR is merged already.
Note I think this is missing the entry for the new output plugin file in the Summary.md to make the docs page?

The summary.md change should also be made, yes!

And I figured out how to do that, so now it'll be in the table of contents when merged.

esmerel and others added 2 commits October 22, 2025 14:36
@esmerel
Apply suggestions from code review
ec86c51 
Merging markdownlint complaints so they're not confusing anyone.

Signed-off-by: Lynette  Miles <[email protected]>
@lecaros @esmerel
out_exit: document new parameters for PR#8621
42b8fef 
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: José Lecaros <[email protected]>
@lecaros lecaros merged commit e8f4a93 into master Oct 23, 2025
7 checks passed
@lecaros lecaros deleted the pwhelan-exit-time-record-docs branch October 23, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esmerel esmerel esmerel requested changes

@edsiper edsiper Awaiting requested review from edsiper

@lecaros lecaros Awaiting requested review from lecaros

Assignees

@eschabell eschabell

Labels

waiting-on-review Waiting on a review from mainteners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pwhelan @eschabell @esmerel @lecaros