-
Notifications
You must be signed in to change notification settings - Fork 1.8k
out_kafka_rest: Add support for Message_Key_Field in sending messages to Kafka Rest #7813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… to Kafka Rest Signed-off-by: TechBRSavvy <[email protected]>
|
@endersonmaia , @leonardo-albertovich , @fujimotos , @koleini Can we have this reviewed? |
|
@endersonmaia , @leonardo-albertovich , @fujimotos , @koleini Ping, can we have this reviewed? |
|
@endersonmaia , @leonardo-albertovich , @fujimotos , @koleini Gentle Reminder, can we have this reviewed? |
2 similar comments
|
@endersonmaia , @leonardo-albertovich , @fujimotos , @koleini Gentle Reminder, can we have this reviewed? |
|
@endersonmaia , @leonardo-albertovich , @fujimotos , @koleini Gentle Reminder, can we have this reviewed? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@endersonmaia , @leonardo-albertovich , @fujimotos , @koleini Gentle Reminder, can we have this reviewed? |
|
@leonardo-albertovich , @fujimotos , @koleini, @edsiper Gentle Reminder, can we have this reviewed? |
|
@leonardo-albertovich , @fujimotos , @koleini, @edsiper Gentle Reminder, can we have this reviewed? |
1 similar comment
|
@leonardo-albertovich , @fujimotos , @koleini, @edsiper Gentle Reminder, can we have this reviewed? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@patrick-stephens can you maybe review this for @TechBRSavvy? |
Currently, Kafka Rest plugin supports only Message_Key which restricts in sending some predefined string as part of it. But this doesn't provide flexibility to choose one of the field from record to be considered as key while pushing the messages to Kafka Rest.
Adding flexibility with choosing one of the field in record as Key (which internally is used for deciding partition in kafka) helps in a way that, all the co-related records are pushed to same partition.
Logic for populating Message Key in below mentioned order
Addresses # 7795
Testing
Before we can approve your change; please submit the following in a comment:
[N/A ] Example configuration file for the change
[ N/A] Debug log output from testing the change
[ N/A] Attached Valgrind output that shows no leaks or memory corruption was found
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.