Skip to content

[verifier] enable COMPATIBILITY_WARNINGS and MISSING_DEPENDENCIES #8362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
*/

import okhttp3.internal.immutableListOf
import org.gradle.api.tasks.testing.logging.TestExceptionFormat
import org.jetbrains.intellij.platform.gradle.IntelliJPlatformType
import org.jetbrains.intellij.platform.gradle.TestFrameworkType
import org.jetbrains.intellij.platform.gradle.models.ProductRelease
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
import org.gradle.api.tasks.testing.logging.TestExceptionFormat

// Specify UTF-8 for all compilations so we avoid Windows-1252.
allprojects {
Expand Down Expand Up @@ -106,19 +106,21 @@ dependencies {
// Plugin dependency documentation:
// https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html#plugins
// https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html#project-setup
bundledPlugins(immutableListOf(
"com.google.tools.ij.aiplugin",
"com.intellij.java",
"com.intellij.properties",
"JUnit",
"Git4Idea",
"org.jetbrains.kotlin",
"org.jetbrains.plugins.gradle",
"org.jetbrains.plugins.yaml",
"org.intellij.intelliLang",
"org.jetbrains.android",
"com.android.tools.idea.smali"
))
bundledPlugins(
immutableListOf(
"com.google.tools.ij.aiplugin",
"com.intellij.java",
"com.intellij.properties",
"JUnit",
"Git4Idea",
"org.jetbrains.kotlin",
"org.jetbrains.plugins.gradle",
"org.jetbrains.plugins.yaml",
"org.intellij.intelliLang",
"org.jetbrains.android",
"com.android.tools.idea.smali"
)
)
plugin("Dart:$dartPluginVersion")

if (sinceBuildInput == "243" || sinceBuildInput == "251") {
Expand Down Expand Up @@ -164,8 +166,8 @@ intellijPlatform {
cliPath = file("./third_party/lib/verifier-cli-1.388-all.jar")
failureLevel = listOf(
// TODO(team) Ideally all of the following FailureLevels should be enabled:
// TODO(team) Create a tracking issue for each of the following validations
// VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS,
// https://github.com/flutter/flutter-intellij/issues/8361
VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS,
VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS,
// VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES, // https://github.com/flutter/flutter-intellij/issues/7718
// VerifyPluginTask.FailureLevel.SCHEDULED_FOR_REMOVAL_API_USAGES,
Expand All @@ -174,7 +176,7 @@ intellijPlatform {
// VerifyPluginTask.FailureLevel.OVERRIDE_ONLY_API_USAGES,
VerifyPluginTask.FailureLevel.NON_EXTENDABLE_API_USAGES,
VerifyPluginTask.FailureLevel.PLUGIN_STRUCTURE_WARNINGS,
// VerifyPluginTask.FailureLevel.MISSING_DEPENDENCIES,
VerifyPluginTask.FailureLevel.MISSING_DEPENDENCIES,
VerifyPluginTask.FailureLevel.INVALID_PLUGIN,
// VerifyPluginTask.FailureLevel.NOT_DYNAMIC,
)
Expand Down