Skip to content

[revert] removal of BagdeIcon #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

[revert] removal of BagdeIcon #8426

merged 1 commit into from
Aug 7, 2025

Conversation

pq
Copy link
Collaborator

@pq pq commented Aug 7, 2025 •
edited
Loading

Reverts #8365.

Fixes: #8422

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from helin24 and jwren August 7, 2025 18:50
@pq pq added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Aug 7, 2025
@pq pq added this to the M88 milestone Aug 7, 2025
jwren
jwren approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you don't mind, follow up with a change in the changelog as well.

@auto-submit auto-submit bot merged commit 8788eac into flutter:master Aug 7, 2025
7 checks passed
@jwren jwren modified the milestones: M88, M87.1 Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwren jwren jwren approved these changes

@helin24 helin24 helin24 approved these changes

Assignees
No one assigned
Labels
autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.
Projects
None yet
Milestone
M87.1
Development

Successfully merging this pull request may close these issues.

ClassCastException: BadgeIcon cannot be cast to ScalableIcon when updating tool window
3 participants
@pq @jwren @helin24