Skip to content

🐛 Set the device selector component to opaque during its creation #8471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 18, 2025

Conversation

AlexV525
Copy link
Member

Fixes #8439
Fixes #7972

This is inspired by StackOverflow, Claude Sonnet 4, and Gemini 2.5 Pro.

Before:
image

After:
image

@AlexV525 AlexV525 added the 🤖 AI-assisted For PRs with significant code generated by AI label Aug 18, 2025
@AlexV525 AlexV525 marked this pull request as draft August 18, 2025 13:45
@AlexV525
Copy link
Member Author

The ultimate solution would be setSmallVariant(true) and modify the styles to be the same as the run configuration or the Android Device Selector. However, I didn't find a proper way to do so. Hope someone is familiar with related stuff.

@AlexV525 AlexV525 marked this pull request as ready for review August 18, 2025 15:24
@jwren jwren merged commit 4b1ffac into flutter:main Aug 18, 2025
7 checks passed
@AlexV525 AlexV525 deleted the fix/component-opaque branch August 18, 2025 16:57
jwren pushed a commit that referenced this pull request Aug 20, 2025
Continue working on
#8471. The PR refactored
the device selector.

**Changes**
1. Now it builds the component without a combo box button and has an
adaptive interface provided by the IntelliJ platform.
2. Device icons are updated to use icons from [Material Symbols
(Rounded)](https://fonts.google.com/icons?icon.size=16&icon.platform=web&icon.set=Material+Symbols&icon.style=Rounded).

This is supported by Claude Sonnet 4 (75%), GPT-5 (20%), and Gemini 2.5
Pro (5%).

**Screenshots**
| Variants | Before | After |
|:---:|:---:|:---:|
| Regular | <img width="412" height="286" alt="image"
src="https://github.com/user-attachments/assets/745632f7-6f96-4810-a07c-7885c35889ba"
/> | <img width="416" height="288" alt="image"
src="https://github.com/user-attachments/assets/b74b5d68-381a-4097-aef4-f2086e232de1"
/> |
| Compact | <img width="396" height="264" alt="image"
src="https://github.com/user-attachments/assets/15075978-1bbb-4191-9382-071fe9b11d60"
/> | <img width="402" height="264" alt="image"
src="https://github.com/user-attachments/assets/a8d73e37-9af4-4e25-afa5-6117d7f98f57"
/> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 AI-assisted For PRs with significant code generated by AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI glitch: rectangular shadow outside device selector button when window is unfocused Device selector does not support default Light theme
2 participants