Run tests on macOS 15.5 or 15.7 #10336
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CI configuration in .ci.yaml to modify the macOS versions for testing. It replaces Mac-14 with Mac-15.7, setting the target operating systems to Mac-15.5 or Mac-15.7. My review highlights that this change removes Mac-14 from the test matrix, which could create a gap in test coverage. I've suggested retaining Mac-14 to ensure continued support while adding the new version.
| {"dependency": "ruby", "version": "ruby_3.1-pod_1.13"} | ||
| ] | ||
| os: Mac-14|Mac-15.5 | ||
| os: Mac-15.5|Mac-15.7 |
There was a problem hiding this comment.
This change removes Mac-14 from the list of operating systems for this test configuration. This could result in an unintended gap in test coverage for macOS 14. To ensure continued testing on the older OS while adding support for Mac-15.7, consider including all three versions.
os: Mac-14|Mac-15.5|Mac-15.7| {"dependency": "ruby", "version": "ruby_3.1-pod_1.13"} | ||
| ] | ||
| os: Mac-14|Mac-15.5 | ||
| os: Mac-15.5|Mac-15.7 |
There was a problem hiding this comment.
Similar to the change above, this removes Mac-14 from the test matrix for x86 CPUs. To maintain test coverage on macOS 14, it is advisable to add Mac-15.7 without removing the existing OS version.
os: Mac-14|Mac-15.5|Mac-15.7
okorohelijah
added
the
autosubmit
flutter/packages@f13bad3...3caa48b 2025-11-06 [email protected] [go_router] Migrates test for leak testing (flutter/packages#10276) 2025-11-06 [email protected] Run tests on macOS 15.5 or 15.7 (flutter/packages#10336) 2025-11-06 [email protected] [pigeon] Encode custom enum as long in Kotlin generator (flutter/packages#10085) 2025-11-06 [email protected] [tool] Ensure that all packages format with correct language version (flutter/packages#10374) 2025-11-06 [email protected] Roll Flutter from e5d5c01 to c5e809a (29 revisions) (flutter/packages#10369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
In preparation of upgrading our fleet to macOS 15.7, allow tests to run on either macOS 15.5 or 15.7.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#176931
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3