[google_maps_flutter] Add cameraControl enable/disable & position on web #9089

4rthurmonteiro · 2025-04-15T19:30:39Z

Add support to camera control button on web.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

harryterkelsen

Thanks for your contribution! This PR looks good to me with a minor nit about improving doc comments. This is ready to split into separate PRs for landing

harryterkelsen · 2025-06-11T21:14:38Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

+  /// See [WebCameraControlPosition] for more details.
+  final WebCameraControlPosition? webCameraControlPosition;
+
+  /// This setting controls how the API handles cameraControl button on the map. Web only.


Have a more descriptive comment here. Something like "Enables or disables the Camera controls."

harryterkelsen

LGTM

stuartmorgan-g · 2025-06-12T12:08:44Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

@@ -349,6 +351,16 @@ class GoogleMap extends StatefulWidget {
  /// See [WebGestureHandling] for more details.
  final WebGestureHandling? webGestureHandling;

+  /// This setting controls how the API handles cameraControl button position on the map. Web only.
+  ///
+  /// See [WebCameraControlPosition] for more details.


The comment should describe what happens if this is null.

stuartmorgan-g · 2025-06-12T12:09:25Z

packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

@@ -2,7 +2,7 @@ name: google_maps_flutter
 description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
 repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
-version: 2.12.1
+version: 2.12.2


As indicated in the PR checklist, we follow semver, which requires changing the minor version when adding public API.

stuartmorgan-g · 2025-06-12T12:10:00Z

packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml

All of the google_maps_flutter_android and google_maps_flutter_ios changes can be reverted.

stuartmorgan-g · 2025-06-12T12:10:46Z

packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.11.2
+
+* Adds support to camera control button on web.


"Adds support for disabling or moving the camera control button on web."

stuartmorgan-g · 2025-06-12T12:11:02Z

...gle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/map_configuration.dart

@@ -44,6 +46,16 @@ class MapConfiguration {
  /// See [WebGestureHandling] for more details.
  final WebGestureHandling? webGestureHandling;

+  /// This setting controls how the API handles cameraControl button position on the map. Web only.
+  ///
+  /// See [WebCameraControlPosition] for more details.


Same comment here; the null behavior should be documented.

stuartmorgan-g · 2025-06-12T12:14:28Z

...lutter/google_maps_flutter_platform_interface/lib/src/types/web_camera_control_position.dart

+| LB          RB | 
+| BL    BC    BR | 
+----------------+
+*/


What's the purpose of duplicating this from the link below? It's not part of the doc comment, and the plugin will never be responsible for actually implementing this behavior, so it's not clear to me who the audience for this comment is.

Good point. I removed the duplicated info.

stuartmorgan-g · 2025-06-12T12:20:40Z

packages/google_maps_flutter/google_maps_flutter_platform_interface/pubspec.yaml

@@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/google_maps_f
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
 # NOTE: We strongly prefer non-breaking changes, even at the expense of a
 # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
-version: 2.11.1
+version: 2.11.2


Same versioning note here.

stuartmorgan-g · 2025-07-29T18:26:52Z

@4rthurmonteiro Are you still planning on updating this based on the feedback above and then splitting out the first sub-PR?

4rthurmonteiro · 2025-07-29T19:41:18Z

@4rthurmonteiro Are you still planning on updating this based on the feedback above and then splitting out the first sub-PR?

Hi @stuartmorgan-g yes!

4rthurmonteiro · 2025-08-06T23:34:13Z

@stuartmorgan-g PR updated with your feedback

stuartmorgan-g

A few more minor comments, but please feel free to proceed with splitting out the platform interface sub-PR in parallel with addressing them.

stuartmorgan-g · 2025-08-14T12:32:56Z

packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.13.0
+
+* Adds support for disabling or moving the camera control button on web.


This change should be made to all the changelogs, not just this one.

@stuartmorgan-g i updated google_maps_flutter, google_maps_platform_interface & google_maps_flutter_web. Android & iOS I didn't. Is it right?

stuartmorgan-g · 2025-08-14T12:33:36Z

packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml

Please revert the newline removals from the Android and iOS pubspecs.

stuartmorgan-g · 2025-08-14T12:39:17Z

...lutter/google_maps_flutter_platform_interface/lib/src/types/web_camera_control_position.dart

+// left-to-right (LTR) and right-to-left (RTL) layout contexts.
+
+// Elements in the top or bottom row flow towards the middle of the row.
+// Elements in the left or right column flow towards the middle of the column.


All of the non doc-comments here should be removed, for the same reason as in my previous review comment; non-doc code comments should be for package maintainers, not clients (since clients will mostly never see them), and package maintainers don't need any of this information. The link below in the doc comment provides all the necessary context, without duplicating its content here.

…rface/lib/src/types/web_camera_control_position.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…erface/camera_control' into feat/camera_control

4rthurmonteiro · 2025-08-27T15:26:49Z

A few more minor comments, but please feel free to proceed with splitting out the platform interface sub-PR in parallel with addressing them.

Hey @stuartmorgan-g and @harryterkelsen the platform-interface PR is here #9897

…into feat/camera_control

…able & position on web (#9897) Platform interface portion of #9089. Part of flutter/flutter#167137 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

4rthurmonteiro · 2025-08-28T19:16:30Z

Hey @stuartmorgan-g and @harryterkelsen the platform web PR is here #9921

4rthurmonteiro added 3 commits April 15, 2025 15:34

feat: camera control on web

b4cc5f8

chore: update map_configuration_test.dart

9281be8

chore: add dependecy_overrides

25020bf

github-actions bot added p: google_maps_flutter platform-web labels Apr 15, 2025

4rthurmonteiro added 2 commits April 21, 2025 15:52

Merge remote-tracking branch 'upstream/main' into feat/camera_control

f2fe01d

chore(step-1): make-deps-path-based

b2d1d89

github-actions bot added platform-android platform-ios labels Apr 21, 2025

chore(changelog): merge with upstream

a5a5ff5

4rthurmonteiro marked this pull request as ready for review April 21, 2025 19:16

4rthurmonteiro requested review from cbracken, reidbaker, ditman and stuartmorgan-g as code owners April 21, 2025 19:16

Merge branch 'main' into feat/camera_control

14a12bf

4rthurmonteiro requested a review from vashworth as a code owner April 24, 2025 00:49

stuartmorgan-g added the triage-web Should be looked at in web triage label May 13, 2025

mdebbar requested a review from harryterkelsen June 11, 2025 18:09

harryterkelsen reviewed Jun 11, 2025

View reviewed changes

harryterkelsen approved these changes Jun 11, 2025

View reviewed changes

stuartmorgan-g requested changes Jun 12, 2025

View reviewed changes

stuartmorgan-g removed the triage-web Should be looked at in web triage label Jun 12, 2025

4rthurmonteiro added 5 commits August 6, 2025 19:43

Merge branch 'main' into feat/camera_control

59403c3

chore: fix minor

a674307

chore: improve webCameraControlEnabled description

67f8332

chore: add doc for WebCameraControlPosition? when is null

89fc4c4

chore: update changelog

34bdf2c

chore: remove overrides

c104583

4rthurmonteiro requested a review from stuartmorgan-g August 6, 2025 23:32

stuartmorgan-g requested changes Aug 14, 2025

View reviewed changes

4rthurmonteiro added 7 commits August 27, 2025 11:37

Merge remote-tracking branch 'upstream/main' into feat/camera_control

2857f31

chore: update google_maps_flutter_web version

48769d3

chore: update google_maps_flutter changelog

bc8995c

chore: undo

e1baafe

chore: update web package changelog

c2db98a

chore: remove non doc-comments

f39f172

chore: revert the newline removals from the Android and iOS pubspecs

1c43687

github-actions bot removed platform-android platform-ios labels Aug 27, 2025

4rthurmonteiro requested a review from stuartmorgan-g August 27, 2025 15:08

feat: add cameraControl enablse/disable

8251ab0

4rthurmonteiro mentioned this pull request Aug 27, 2025

[google_maps_flutter_platform_interface] Add cameraControl enable/disable & position on web #9897

Merged

11 tasks

4rthurmonteiro and others added 2 commits August 27, 2025 12:23

Update packages/google_maps_flutter/google_maps_flutter_platform_inte…

e919f3d

…rface/lib/src/types/web_camera_control_position.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Merge remote-tracking branch 'origin/google_maps_flutter_platform_int…

e8bbbb5

…erface/camera_control' into feat/camera_control

4rthurmonteiro added 4 commits August 27, 2025 16:28

chore: update docs

a53dea0

Merge branch 'google_maps_flutter_platform_interface/camera_control' …

bfa3f44

…into feat/camera_control

Merge branch 'main' into feat/camera_control

2296090

chore: add webCameraControlPosition test

aff20e2

4rthurmonteiro added 3 commits August 28, 2025 15:02

Merge remote-tracking branch 'upstream/main' into feat/camera_control

e3a17f9

chore: remove platform interface override

a4c3b7c

chore: remove platform interface override

bd44dad

4rthurmonteiro mentioned this pull request Aug 28, 2025

[google_maps_flutter_web] Add cameraControl enable/disable & position on web #9921

Open

11 tasks

vashworth removed their request for review August 28, 2025 21:44

		@@ -1,3 +1,7 @@
		## 2.11.2

		* Adds support to camera control button on web.

		@@ -1,3 +1,7 @@
		## 2.13.0

		* Adds support for disabling or moving the camera control button on web.

[google_maps_flutter] Add cameraControl enable/disable & position on web #9089

Are you sure you want to change the base?

[google_maps_flutter] Add cameraControl enable/disable & position on web #9089

Uh oh!

Conversation

4rthurmonteiro commented Apr 15, 2025 • edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jul 29, 2025

Uh oh!

4rthurmonteiro commented Jul 29, 2025

Uh oh!

4rthurmonteiro commented Aug 6, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4rthurmonteiro commented Aug 27, 2025

Uh oh!

4rthurmonteiro commented Aug 28, 2025

Uh oh!

Uh oh!

4rthurmonteiro commented Apr 15, 2025 •

edited by stuartmorgan-g

Loading