-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[image_picker] Add the ability to pick multiple videos - platform implementations #9818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image_picker] Add the ability to pick multiple videos - platform implementations #9818
Conversation
…va/io/flutter/plugins/imagepicker/ImagePickerDelegate.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the ability to pick multiple videos by introducing the getMultiVideoWithOptions
method. The feature is implemented across Android, iOS, web, Linux, and macOS platforms. The changes include necessary native code modifications, Dart API implementations, updates to example applications to demonstrate the new functionality, and additions to the test suites to ensure correctness. A significant refactoring was also done in the iOS implementation to unify the picker launching logic. The overall implementation is solid, but I found a minor issue in one of the new tests.
Platform implementation portion of #9775
This adds support for the new
getMultiVideoWithOptions
method to all implementation packages.Part of flutter/flutter#102283
Fixes flutter/flutter#146400
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3