Optionally propagate keydown events #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can leverage default keydown behaviors provided by the browser, such as tabbing to the next input. The default behavior was the previous behavior, so that this is not a breaking change.
Author
|
The prop should also be added to tokenizer's render method. Althought it doesn't work very well with the tokenizer. When you search and press tab, a list item gets selected and focus immediately jumps to the next HTML element. In the case of the tokenizer, I think the focus should remain in the search input after selecting a list item and should jump to the next HTML element after pressing tab again, if the input is empty. |
To make this useful for the tokenizer, we also take steps to keep the focus on the tokenizer input, unless the input is empty. We reuse the logic that determines whether "backspace" should clear a token, or do it's default behavior.
Author
|
I just guessed at what might work for the tokenizer. I haven't been using the Tokenizer at all, and don't have anything set up to actually test that change out. I'll eventually get around to it, but if you happen to try it out, let me know if it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can leverage default keydown behaviors provided by the
browser, such as tabbing to the next input.
The default behavior is the previous behavior, so that this is not a
breaking change.