-
Notifications
You must be signed in to change notification settings - Fork 50
Waypoint #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macgyver912
wants to merge
14
commits into
fmrico:master
Choose a base branch
from
macgyver912:waypoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Waypoint #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compile el nuevo fichero .h y .cpp
…ar funcionalidad con position.
…independiente del ángulo y zoom de la cámara.
…stas de <ATCDRoute> por listas de <ATCDLegs> que son listas de estructuras que contienen struct de tipo Route y objetos de tipo Waypoint. Commit para sincronización con PC de Aulas Informáticas URJC
… cargar los Waypoint desde un fichero externo y que sea visible desde AirController. Después, generar clase TestWaypoint que pruebe todas las funcionalidades.
- Se ha corregido un bug por el que la altitud no se asignaba en la interfaz gráfica cuando se hacía uso de Waypoint. - Ahora los Waypoints se cargan (de momento se generan en código) en Airport.cpp y están disponibles en AirController.cpp para acceder a ellos a través de un map<std::string, Waypoint> de tal forma que se pueda asignar cómodamente un Waypoint a la ruta. - Si un Waypoint no se encuentra en la lista, se asignará un Position en su lugar. - Si al siguiente punto de la ruta se le ha asignado un Position y un Waypoint, el Waypoint tiene preferencia (se comprueba si el nombre del Waypoint no es vacío). Tareas pendientes: - Cargar puntos desde fichero externo. - Crear clase TestWaypoint que pruebe las funcionalidades.
…rear y obtener Waypoints. Con esto se cumple el requisito de @fmrico de que los Waypoints no se gestionen desde la clase Airport, sino desde AirController.
…irControllerUtils.
…eros también, a excepción de que el CMakeLists.txt que existe en fmrico/master da error de compilación: - En casa: [ 77%] Linking CXX executable ATCSim /usr/bin/ld: CMakeFiles/ATCSim.dir/src/simulator/ATCSim.cpp.o: referencia sin definir al símbolo '_ZN7IceUtil9ExceptionC2Ev' //usr/lib/x86_64-linux-gnu/libIceUtil.so.35: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status CMakeFiles/ATCSim.dir/build.make:97: fallo en las instrucciones para el objetivo 'ATCSim' make[2]: *** [ATCSim] Error 1 CMakeFiles/Makefile2:181: fallo en las instrucciones para el objetivo 'CMakeFiles/ATCSim.dir/all' make[1]: *** [CMakeFiles/ATCSim.dir/all] Error 2 Makefile:94: fallo en las instrucciones para el objetivo 'all' make: *** [all] Error 2 - En PCs URJC (ssh @beta): CMakeFiles/cmTC_ef389.dir/CheckSymbolExists.c.o: En la función pthread_create' sin definir collect2: error: ld returned 1 exit status CMakeFiles/cmTC_ef389.dir/build.make:97: recipe for target 'cmTC_ef389' failed make[1]: *** [cmTC_ef389] Error 1 make[1]: se sale del directorio '/home/alumnos/jvalle/ProgramacionAvanzada/Proyecto/ATCSim/build/CMakeFiles/CMakeTmp' Makefile:126: recipe for target 'cmTC_ef389/fast' failed make: *** [cmTC_ef389/fast] Error 2 File /home/alumnos/jvalle/ProgramacionAvanzada/Proyecto/ATCSim/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c: /* */ #include <pthread.h> int main(int argc, char** argv) { (void)argv; #ifndef pthread_create return ((int*)(&pthread_create))[argc]; #else (void)argc; return 0; #endif } Determining if the function pthread_create exists in the pthreads failed with the following output: Change Dir: /home/alumnos/jvalle/ProgramacionAvanzada/Proyecto/ATCSim/build/CMakeFiles/CMakeTmp Run Build Command:/usr/bin/make cmTC_22a02/fast /usr/bin/make -f CMakeFiles/cmTC_22a02.dir/build.make CMakeFiles/cmTC_22a02.dir/build make[1]: se entra en el directorio '/home/alumnos/jvalle/ProgramacionAvanzada/Proyecto/ATCSim/build/CMakeFiles/CMakeTmp' Building C object CMakeFiles/cmTC_22a02.dir/CheckFunctionExists.c.o /usr/bin/cc -DCHECK_FUNCTION_EXISTS=pthread_create -o CMakeFiles/cmTC_22a02.dir/CheckFunctionExists.c.o -c /usr/share/cmake-3.10/Modules/CheckFunctionExists.c Linking C executable cmTC_22a02 /usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_22a02.dir/link.txt --verbose=1 /usr/bin/cc -DCHECK_FUNCTION_EXISTS=pthread_create -rdynamic CMakeFiles/cmTC_22a02.dir/CheckFunctionExists.c.o -o cmTC_22a02 -lpthreads /usr/bin/ld: no se puede encontrar -lpthreads collect2: error: ld returned 1 exit status CMakeFiles/cmTC_22a02.dir/build.make:97: recipe for target 'cmTC_22a02' failed make[1]: *** [cmTC_22a02] Error 1 make[1]: se sale del directorio '/home/alumnos/jvalle/ProgramacionAvanzada/Proyecto/ATCSim/build/CMakeFiles/CMakeTmp' Makefile:126: recipe for target 'cmTC_22a02/fast' failed make: *** [cmTC_22a02/fast] Error 2
This was referenced Dec 10, 2018
Open
Merged
This was referenced Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola @fmrico.
He terminado con toda la funcionalidad necesaria del Issue #29.
He hecho merge con fmrico/master y todo funciona bien (veo las mejoras visuales del avión, etc), pero el CMakeList.txt actual de fmrico/master produce errores.
Para más detalles de estos errores ver Commit: 8416a07