Soluciono problemas de estilo de Position test #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hola @rdelgadoaguilera , No tengo muy claro si mejoras o empeoras el estilo. Tus tabs son muy grandes, cuando lo normal son 2 o 4 espacios, como están ahora. Además, utilizas el |
fmrico
requested changes
Jan 7, 2019
| #include "gtest/gtest.h" | ||
| #include "Position.h" | ||
|
|
||
| using namespace atcsim; |
|
|
||
| TEST(PositionTest, empty_constructor) | ||
| { | ||
| Position pos; |
|
Se debe a que he usado los tabuladores por defecto del programa de wdicion. ¿Que debo hacer? |
|
poner dos espacios en lugar de un tab, o configurar bien tu editor. Tienes conflictos... |
|
Quieres añadir ATCDisplay* en este commit. Estos ficheros son autogenerados y no deberían subirse nunca. Limita tu PR al fichero de test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrijo los fallos que había anteriormente.