Claude Code markdown - #1470
Merged
Merged
Conversation
trueqbit
force-pushed
the
claude-config
branch
from
December 9, 2025 18:44
49ede20 to
137491e
Compare
trueqbit
force-pushed
the
claude-config
branch
from
December 9, 2025 18:50
137491e to
2564fcc
Compare
fnc12
approved these changes
Dec 9, 2025
Owner
|
@trueqbit let's fix the conflicts and merge it |
Add docs/internals/ describing how the dev/ headers are layered and where a new trait, predicate or algorithm belongs: the vocabulary traits/algorithms and schema-level tiers, the five trait axes, open vs. closed and the two independent reasons for a _fwd/impl split, the constraint that concepts place on splitting, and the role of the node_definitions.h manifests. Record decided-but-not-yet-done work separately from genuinely open questions: traits still to be lifted out of their concrete node headers, the storage_* -> schema_* renames for storage_traits.h and storage_lookup.h, and type_printer's migration. Note in structural_traits_fwd.h that quoting nodes are structural traits and that a future quoting_traits_fwd.h would be a subdivision of that axis rather than a new one. Link the new documentation from docs/home.md. Update CLAUDE.md to match the current tree: point at the new internal documentation as the authority on header placement, summarize the placement test, add a checklist for adding a DSL node (registering it in node_definitions.h is a silent failure if skipped), list the directories that were missing from the file map, note that include/sqlite_orm/sqlite_orm.h is generated from dev/, and correct the stale line counts and branch section. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hg5oKpMASvsiw4ZCZiDNPr
The repository instructions were tied to one tool by filename and by their opening line. Move them to AGENTS.md, the cross-tool convention, and reword the preamble to address AI coding agents generally. Keep CLAUDE.md as a pointer to AGENTS.md so Claude Code still finds the instructions, and state there that guidance belongs in AGENTS.md rather than in the pointer file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hg5oKpMASvsiw4ZCZiDNPr
storage_lookup.h sat at the top level and mixed two things: generic facilities for the tuple of database objects, and the algorithms that search that tuple for a table. Split them and put each where it belongs. The lookup algorithms move to schema/algorithms/table_lookup.h, alongside sync_order.h. They search across the collection of database objects rather than classifying a node already in hand, which is what the vocabulary layer does. Rename storage_pick_table[_t] and storage_find_table[_t] accordingly to schema_pick_table[_t] and schema_find_table[_t]: these operate on the schema, the mapped database objects, not on the storage_t object. The generic half (db_objects_tuple, is_db_objects, db_objects_for_expression) is not an algorithm and moves to schema/db_objects.h. Include sites now pull in whichever of the two headers they actually use. Drop is_storage, and with it the forward declaration of storage_t that existed only to serve it. It had no users other than the static test asserting on it. Record at file level that lookup covers tables in the wide SQL sense - base tables, views and virtual tables - and deliberately not indexes or triggers, whose void object_type object_type_matches filters out. Also drop an unused include from udf_existence_checker.h. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hg5oKpMASvsiw4ZCZiDNPr
fnc12
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am successfully using Claude when working with the library, and Claude produced a rather good CLAUDE markdown file that provides guidance to Claude Code when working with code in this repository.
I thought I add it to the repo.
As of 2026-08-15 this PR also contains:
AGENTS.mdfile.dev/storage_lookup.hunderdev/schema/db_objects.hrespectivelydev/schema/algorithms/table_lookup.h.