Enhance MSSQL class to accept workstation ID and application name parameters #2074
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anadrianmanrique
added
the
enhancement
gabrielg5
requested changes
Nov 18, 2025
Collaborator
gabrielg5
left a comment
gabrielg5
left a comment
There was a problem hiding this comment.
hey hello, thank you for this PR!
Think it's ok. Added some "OCD" suggestions :D just to leverage the getters you included in the PR.
Checking examples leveraging the MSSQL class, I think would be good add 2 new parameters to the mssqlclient one, to allow users configuring these connection properties (fallback to "" as now, to randomize them)
Thinking long term, to check in future PRs eventually, can be leveraged from ntlmrelayx as well to reuse client properties - in cases they are set -
gabrielg5
added
the
waiting for response
Co-authored-by: Gabriel Gonzalez <[email protected]>
Co-authored-by: Gabriel Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I want to add this piece of code to enable developers to modify the
Workstation IDandApplication Namewhen using the TDS protocol with theMSSQLclass.This allows the security team to leave IoCs or, conversely, enables red activities to be more covert by using things commonly found in the targeted environment.
It's a small PR, but useful!
Best regards,