Do concurrent #59
Open
Do concurrent #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage ? 82.76%
=======================================
Files ? 67
Lines ? 2170
Branches ? 182
=======================================
Hits ? 1796
Misses ? 374
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Co-authored-by: ZUO Zhihua <[email protected]>
Intent specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the loops that could be replaced by
do concurrenthave been.On my laptop, here are the timings I gets:
Legacy code:
bench01_zfft: 3.19 secondsbench02_zfft: 4.10 secondsbench03_dfft: 1.80 secondsDo-concurrent code:
bench01_zfft: 2.26 seconds (1.4x speedup)bench02_zfft: 2.90 seconds (1.4x speedup)bench03_dfft: 1.50 seconds (1.2x speedup)Both codes are compiled with
gfortran 13.3. The speed-ups are obviously to be taken with a grain of salt. We would need to do a proper performances analysis with sequences of varying lengths. Still, it's pretty nice I believe.ping @perazz @zoziha
PS : This PR builds upon the
intent_specsone and should be merge after the latter.