-
Notifications
You must be signed in to change notification settings - Fork 814
feat: added functionality for Wave Generator #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AsCress
wants to merge
1
commit into
fossasia:flutter
Choose a base branch
from
AsCress:wavegen_func
base: flutter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideIntroduces Wave Generator state management by adding WaveConst and WaveData enums and implementing a ChangeNotifier-based provider to track wave selection states. Entity relationship diagram for Wave Generator enumserDiagram
WAVE_CONST {
ENUM waveType
ENUM wave1
ENUM wave2
ENUM sqr1
ENUM sqr2
ENUM sqr3
ENUM sqr4
ENUM frequency
ENUM phase
ENUM duty
ENUM square
ENUM pwm
}
WAVE_DATA {
ENUM freqMin
ENUM dutyMin
ENUM phaseMin
ENUM freqMax
ENUM phaseMax
ENUM dutyMax
INT value
}
WAVE_CONST ||--o{ WAVE_GENERATOR_STATE_PROVIDER : uses
WAVE_DATA ||--o{ WAVE_GENERATOR_STATE_PROVIDER : uses
Class diagram for Wave Generator state managementclassDiagram
class WaveGeneratorStateProvider {
+bool isAnalogWaveSelected
+bool isSine1Selected
+bool isSine2Selected
+bool isDigitalWaveSelected
+bool isSqr1Selected
+bool isSqr2Selected
+bool isSqr3Selected
+bool isSqr4Selected
+WaveGeneratorStateProvider()
}
class WaveConst {
}
class WaveData {
+int value
+WaveData(int value)
+int getValue
}
WaveGeneratorStateProvider --|> ChangeNotifier
WaveData <|-- enum
WaveConst <|-- enum
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/16971347520/artifacts/3767247032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functionality for the Wave Generator instrument.
Summary by Sourcery
Introduce state management for the Wave Generator instrument with enums for constants and data limits and a ChangeNotifier provider to track selected wave types.
New Features: