Internationalization #193

vedansh-5 · 2025-07-10T19:21:59Z

📌 Fixes

Fixes #159

📝 Summary of Changes

All the labels of extension changes according to the default language set in users' browser.

📸 Screenshots / Demo (if UI-related)

✅ Checklist

I’ve tested my changes locally
I’ve added tests (if applicable)
I’ve updated documentation (if applicable)
My code follows the project’s code style guidelines

👀 Reviewer Notes

Add any special notes for the reviewer here

Summary by Sourcery

Externalize all user-facing text into localized message files and apply internationalization across the extension’s UI based on the user’s browser language.

New Features:

Add locale-specific messages.json files and default_locale configuration in manifest.json
Implement applyAllTranslations in popup.js to load and insert localized UI strings

Enhancements:

Replace all hardcoded labels, placeholders, button texts, and tooltips in popup.html with data-i18n attributes
Refactor JS handlers to use chrome.i18n.getMessage for dynamic UI text, placeholders, titles, and status messages

Signed-off-by: Vedansh Saini <[email protected]>

sourcery-ai · 2025-07-10T19:22:04Z

Reviewer's Guide

This PR implements internationalization by annotating UI elements in popup.html with data-i18n attributes, introducing locale JSON files under src/_locales, and wiring up translation logic in popup.js using the chrome.i18n API, along with updating manifest.json to specify the default locale.

File-Level Changes

Change	Details	Files
Annotated UI text in popup.html with i18n attributes	Replaced static headings, labels and button texts with data-i18n and data-i18n-placeholder attributes Wrapped dynamic text inside tags and added data-i18n-title for tooltips/titles Converted hardcoded button labels and tooltips to use data-i18n spans	`src/popup.html`
Added localization resource files and default locale configuration	Created locale directories (de, en, es, fr, zh_CN) each containing messages.json Updated manifest.json to include "default_locale": "en"	`src/manifest.json` `src/_locales/de/messages.json` `src/_locales/en/messages.json` `src/_locales/es/messages.json` `src/_locales/fr/messages.json` `src/_locales/zh_CN/messages.json`
Implemented translation initialization in popup.js	Added applyAllTranslations() to replace texts, placeholders, and titles at startup Invoked applyAllTranslations() on DOMContentLoaded before other logic Replaced inline hardcoded status and button strings with chrome.i18n.getMessage calls	`src/scripts/popup.js`

Assessment against linked issues

Issue	Objective	Addressed	Explanation

Possibly linked issues

Add i18n Support for Browser Language-Based Translations #159: The PR implements internationalization to adapt extension labels to the user's browser language as requested by the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @vedansh-5 - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/scripts/popup.js:240` </location>
<code_context>
             // Allow empty org to fetch all GitHub activities
             chrome.storage.local.set({ orgName: org }, () => {
-                generateBtn.innerHTML = '<i class="fa fa-spinner fa-spin"></i> Generating...';
+                generateBtn.innerHTML = `<i class="fa fa-spinner fa-spin"></i> ${chrome.i18n.getMessage('generatingButton')}`;
                 generateBtn.disabled = true;
                 window.generateScrumReport();
</code_context>

<issue_to_address>
No fallback for missing 'generatingButton' i18n key.

If the i18n key is missing, only the spinner appears. Please add a fallback string to improve user experience.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
                generateBtn.innerHTML = `<i class="fa fa-spinner fa-spin"></i> ${chrome.i18n.getMessage('generatingButton')}`;
=======
                const generatingText = chrome.i18n.getMessage('generatingButton') || 'Generating...';
                generateBtn.innerHTML = `<i class="fa fa-spinner fa-spin"></i> ${generatingText}`;
>>>>>>> REPLACE

</suggested_fix>

### Comment 2
<location> `src/scripts/popup.js:458` </location>
<code_context>
                     const scrumReport = document.getElementById('scrumReport');
                     if (scrumReport) {
-                        scrumReport.innerHTML = '<p style="text-align: center; color: #666; padding: 20px;">Organization changed. Click Generate button to fetch the GitHub activities.</p>';
+                        scrumReport.innerHTML = `<p style="text-align: center; color: #666; padding: 20px;">${chrome.i18n.getMessage('orgChangedMessage')}</p>`;
                     }
                     // Clear the githubCache for previous org
</code_context>

<issue_to_address>
No fallback for missing 'orgChangedMessage' i18n key.

Without a fallback, the report may display nothing if the key is missing. Please add a default message to ensure the UI remains informative.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
                    if (scrumReport) {
                        scrumReport.innerHTML = `<p style="text-align: center; color: #666; padding: 20px;">${chrome.i18n.getMessage('orgChangedMessage')}</p>`;
                    }
=======
                    if (scrumReport) {
                        const orgChangedMsg = chrome.i18n.getMessage('orgChangedMessage') || 'Organization changed. Click Generate button to fetch the GitHub activities.';
                        scrumReport.innerHTML = `<p style="text-align: center; color: #666; padding: 20px;">${orgChangedMsg}</p>`;
                    }
>>>>>>> REPLACE

</suggested_fix>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/scripts/popup.js

Signed-off-by: Vedansh Saini <[email protected]>

hpdang · 2025-07-11T17:07:11Z

@vedansh-5 it doesn't work, please see screenshot

vedansh-5 · 2025-07-11T18:45:24Z

@vedansh-5 it doesn't work, please see screenshot

That's really weird, because

It works on my machine.
Could you please open up your chrome developer tools and check/share the console errors. Thankyou

vedansh-5 · 2025-07-11T18:59:45Z

@Preeti9764 Could you also review this and see if the same error persists for you. Thanks

Signed-off-by: Vedansh Saini <[email protected]>

vedansh-5 · 2025-07-12T19:56:24Z

@Preeti9764 Please take a look whenever you can, thanks,

vedansh-5 · 2025-07-14T13:33:59Z

@Preeti9764 Please review this PR and share your views on this. Thanks!

hpdang · 2025-07-16T05:11:20Z

@vedansh-5 please solve conflicts and we don't need to translate the name of the extension, just like other names "GitHub or GitLab"

Signed-off-by: Vedansh Saini <[email protected]>

hpdang · 2025-07-16T13:43:07Z

@vedansh-5 how can a user use this feature? Thanks

hpdang · 2025-07-16T14:16:21Z

I switched my browser to Vn but I didn't see the translated version of the extension

vedansh-5 · 2025-07-16T14:44:43Z

I switched my browser to Vn but I didn't see the translated version of the extension

There have been some issues after a rebase, I'd resolve them soon.

Signed-off-by: Vedansh Saini <[email protected]>

vedansh-5 · 2025-07-16T19:10:17Z

@hpdang @Preeti9764 Please test the new code changes. It works properly now. Thankyou!

Signed-off-by: Vedansh Saini <[email protected]>

vedansh-5 · 2025-07-17T17:11:18Z

@Preeti9764 @hpdang Please review this whenever you have some free time, thankyou.

hpdang · 2025-07-17T18:32:28Z

It still doesn't work for me actually. Maybe I missed as a step? How should I test it? I set my browser preferred language to Vietnamese. And other app such as Eventyay UI is automatically translated to Vn.

Preeti9764 · 2025-07-18T08:13:59Z

for me it gets changed for extension , as well the browser language as changed the default language

vedansh-5 · 2025-07-18T13:48:35Z

It still doesn't work for me actually. Maybe I missed as a step? How should I test it? I set my browser preferred language to Vietnamese. And other app such as Eventyay UI is automatically translated to Vn.

Missing a step would be unlikely, You have to change the preferred language and then relaunch the browser. This should automatically translate the extension.
Are you also facing the issue you were earlier, in which no labels were shown in the extension body?

vedansh-5 · 2025-07-19T19:47:01Z

@hpdang

for me its translating, could you please confirm whether your browser is up-to-date.

Preeti9764 · 2025-07-21T06:36:15Z

@hpdang @vedansh-5 when i switch my broswer deafult language it translate for my extension language too, working for me.Thanks!

vedansh-5 added 2 commits July 11, 2025 00:37

internationalization

2afd0e1

Signed-off-by: Vedansh Saini <[email protected]>

addded more langs

8bc7a05

Signed-off-by: Vedansh Saini <[email protected]>

sourcery-ai bot reviewed Jul 10, 2025

View reviewed changes

src/scripts/popup.js Show resolved Hide resolved

src/scripts/popup.js Outdated Show resolved Hide resolved

notes are now translatable, added more lans

dec0519

Signed-off-by: Vedansh Saini <[email protected]>

vedansh-5 self-assigned this Jul 10, 2025

vedansh-5 requested review from hpdang and Preeti9764 July 10, 2025 19:42

dummy commit

4261121

Signed-off-by: Vedansh Saini <[email protected]>

vedansh-5 added 5 commits July 16, 2025 12:16

no translation in extension name

1c3e9fa

Signed-off-by: Vedansh Saini <[email protected]>

no translation in extension name

b0190e3

Signed-off-by: Vedansh Saini <[email protected]>

no translation for github

e5e99d9

Signed-off-by: Vedansh Saini <[email protected]>

instructions to add a new language

7b3ffa0

Signed-off-by: Vedansh Saini <[email protected]>

Merge branch 'master' into language

3797177

vedansh-5 force-pushed the language branch from a5e0224 to 3797177 Compare July 16, 2025 08:06

properly translating now

3cc236a

Signed-off-by: Vedansh Saini <[email protected]>

formatting

07740c7

Signed-off-by: Vedansh Saini <[email protected]>

hpdang merged commit 942363c into fossasia:master Jul 21, 2025

Internationalization #193

Internationalization #193

Uh oh!

Conversation

vedansh-5 commented Jul 10, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Fixes

📝 Summary of Changes

📸 Screenshots / Demo (if UI-related)

✅ Checklist

👀 Reviewer Notes

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hpdang commented Jul 11, 2025

Uh oh!

vedansh-5 commented Jul 11, 2025

Uh oh!

vedansh-5 commented Jul 11, 2025

Uh oh!

vedansh-5 commented Jul 12, 2025

Uh oh!

vedansh-5 commented Jul 14, 2025

Uh oh!

hpdang commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hpdang commented Jul 16, 2025

Uh oh!

hpdang commented Jul 16, 2025

Uh oh!

vedansh-5 commented Jul 16, 2025

Uh oh!

vedansh-5 commented Jul 16, 2025

Uh oh!

vedansh-5 commented Jul 17, 2025

Uh oh!

hpdang commented Jul 17, 2025

Uh oh!

Preeti9764 commented Jul 18, 2025

Uh oh!

vedansh-5 commented Jul 18, 2025

Uh oh!

vedansh-5 commented Jul 19, 2025

Uh oh!

Preeti9764 commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vedansh-5 commented Jul 10, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jul 10, 2025 •

edited

Loading

hpdang commented Jul 16, 2025 •

edited

Loading

Preeti9764 commented Jul 21, 2025 •

edited

Loading