fix: enable edge coverage only when needed #11041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
previously approved these changes
Jul 18, 2025
DaniPopes
requested review from
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
|
Anything else to do here? |
Per @0xalpharush would be good to also add a config to enable the edge coverage and metrics, but not use corpus/mutations, useful for benchmarking. |
mattsse
previously approved these changes
Jul 19, 2025
zerosnacks
previously approved these changes
Jul 19, 2025
|
going to make it adhere to show_metrics flag and move logic to enable edge inspector only for invariant executor |
grandizzy
dismissed stale reviews from zerosnacks, mattsse, and DaniPopes
via
3eb0845
grandizzy
force-pushed
the
optional-edge-inspector
branch
from
f4bd627 to
3eb0845
Compare
grandizzy
force-pushed
the
optional-edge-inspector
branch
from
3eb0845 to
0d9b0f5
Compare
|
grandizzy
changed the title
grandizzy
changed the title
DaniPopes
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
show_edge_coveragesetting - useful for benchmarkingSolution
PR Checklist