Adds test files inclusion for Voyager verification #3550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a `--test-files` flag to the `verify` command. This flag allows users to include test files located under the `src/` directory during contract verification with the Voyager verifier. This ensures that all relevant source code, including test-related code, is considered during the verification process, providing a more comprehensive and accurate verification result.
ddoktorski
reviewed
Jul 16, 2025
crates/sncast/tests/data/contracts/map_with_tests/src/lib.cairo
Outdated
Show resolved
Hide resolved
Extends Voyager tests to assert that the presence or absence of test files in the request to Voyager is correct. This ensures that the test files flag functions as expected.
Updates the Voyager tests to reflect changes in the location of the contract files. Simplifies the directory structure by removing the redundant `map_with_tests` directory and using `map` instead. This change improves code maintainability and test clarity.
The `--test-files` flag is not supported when using the Walnut verifier. This change throws an error when a user attempts to use the flag with the Walnut verifier to prevent unexpected behavior.
ddoktorski
reviewed
Jul 21, 2025
Co-authored-by: ddoktorski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminal
Adds --test-files flag to include test files in Voyager verification.
This change introduces a new
--test-filesflag to the sncast verify command. When used with the Voyager verifier, this flag includes files in the src/ directory, even those containing "test" in their path, in the source code uploaded for verification.Changes
test_filesboolean field to the Verify struct incrates/sncast/src/starknet_commands/verify/mod.rswith a default value of false.crates/sncast/src/starknet_commands/verify/mod.rsto pass thetest_filesflag to the verifier implementations.VerificationInterfacetrait incrates/sncast/src/starknet_commands/verify/explorer.rsto include a test_files parameter in the verify method.Voyager::verifyimplementation incrates/sncast/src/starknet_commands/verify/voyager.rsto accept thetest_filesflag and pass it toself.gather_files.Voyager::gather_filesfunction to pass theinclude_test_filesflag to thepackage_source_filesfunction.package_source_filesfunction to include or exclude test files based on theinclude_test_filesflag. Added logic to walk through the path and check for "test" in the lowercase representation.map_with_testsincluding source and test files undercrates/sncast/tests/data/contracts/.--test-filesflag works correctly by using the new test contract.Impact
sncast verifycommand now accepts a--test-files flag.--test-filesflag is used with the Voyager verifier, test files undersrc/are included in the verification process.test_filesflag.