Skip to content

Restore command field in sncast json responses #3551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Restore command field in sncast json responses #3551

wants to merge 23 commits into from

Conversation

franciszekjob
Copy link
Contributor

@franciszekjob franciszekjob commented Jul 14, 2025 •
edited
Loading

Closes #

Introduced changes

sncast responses (used with with --json flag) didn't include command field in success case, now they do.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

ddoktorski and others added 21 commits July 11, 2025 12:11
@ddoktorski
Support RPC 0.9.0
ea52319
@franciszekjob
Restore command field in sncast json responses
183aea9
@franciszekjob
Update other's case in to_json
3d227d0
@ddoktorski
Merge branch 'master' into rpc-0-9-0
bbfb650
@ddoktorski
Rename preconfirmed to pre_confirmed
d5b0302
@ddoktorski
Update version to 0.9 in node url
a0d4f6a
@ddoktorski
Restore ignored tests
2c20aca
@ddoktorski
Add backticks
2c599e1
@ddoktorski
Update changelog
3d1c5aa
@ddoktorski
Fix test_happy_case_deployment_fee_message test
802462b
@ddoktorski
Add dash to pre confirmed
764611e
@ddoktorski
Bump devnet to rc.2
7dc04ca
@ddoktorski
Resolve merge conflicts
f0bbc6e
@ddoktorski
Address PR comments
808625a
@ddoktorski
Use always underscore for pre_confirmed input
d1721df
@ddoktorski
Revert refactor in check_if_legacy_contract
38ce1d5
@ddoktorski
Resolve merge conflicts
c8ad731
@ddoktorski
Bump starknet-rs to rc.2; bump devnet to rc.4
35ab8a2
@ddoktorski
Fix changelog
8b28a91
@ddoktorski
Fix e2e::forking::with_cache test
34bbd0c
@franciszekjob
Merge branch 'rpc-0-9-0' into restore-command-field-in-sncast-jsons
6c8c28b
Base automatically changed from rpc-0-9-0 to master August 21, 2025 19:51
@github-actions GitHub Actions
Copy link

Hi! This pull request hasn't had any activity for a while, so I am
marking it as stale. It will close in 14
days if it is not updated. Thanks for contributing!

@github-actions github-actions bot added the stale Stale Bot label Sep 22, 2025
@franciszekjob franciszekjob mentioned this pull request Sep 25, 2025
Merged
1 task
@github-actions github-actions bot removed the stale Stale Bot label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciszekjob @ddoktorski