-
Notifications
You must be signed in to change notification settings - Fork 235
Add tests for cheat_account_contract_address
cheatcode
#3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add tests for cheat_account_contract_address
cheatcode
#3722
Conversation
Hey @naijauser some checks are failing. Are you planning to update the PR? |
Hi, yes I would update this. It's not complete yet. Got caught up with a lot lately. |
Hi @cptartur , I've updated the PR. There are other tests that are not yet covered e.g LibCall, Proxy contracts e.t.c for the cheatcode. I'll add those in a separate PR. Please take a look, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @naijauser
Thanks for your contribution! It looks good, I've added just two minor comments
crates/cheatnet/tests/cheatcodes/cheat_account_contract_address.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the contract implementation to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other contract types that will be covered in later tests like library_call, proxy, and others.
They will be added here.
It follows the same pattern as existing tests in the codebase. @ddoktorski
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually can we simply extend the existing CheatTxInfoChecker
with a method to get account_contract_address
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, okay. That's a good idea. I'll explore that option.
…s.rs Co-authored-by: ddoktorski <[email protected]>
Advances #2145
Introduced changes
cheat_account_contract_address
cheatcodeChecklist
CHANGELOG.md