Skip to content

Conversation

naijauser
Copy link
Contributor

Advances #2145

Introduced changes

  • Adds tests for cheat_account_contract_address cheatcode

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@cptartur
Copy link
Member

Hey @naijauser some checks are failing. Are you planning to update the PR?

@naijauser
Copy link
Contributor Author

Hey @naijauser some checks are failing. Are you planning to update the PR?

Hi, yes I would update this. It's not complete yet.

Got caught up with a lot lately.

@naijauser naijauser marked this pull request as ready for review September 17, 2025 17:59
@naijauser naijauser requested a review from a team as a code owner September 17, 2025 17:59
@naijauser
Copy link
Contributor Author

Hey @naijauser some checks are failing. Are you planning to update the PR?

Hi, yes I would update this. It's not complete yet.

Got caught up with a lot lately.

Hi @cptartur , I've updated the PR.

There are other tests that are not yet covered e.g LibCall, Proxy contracts e.t.c for the cheatcode.

I'll add those in a separate PR.

Please take a look, thanks.

Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naijauser
Thanks for your contribution! It looks good, I've added just two minor comments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the contract implementation to this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other contract types that will be covered in later tests like library_call, proxy, and others.

They will be added here.

It follows the same pattern as existing tests in the codebase. @ddoktorski

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually can we simply extend the existing CheatTxInfoChecker with a method to get account_contract_address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay. That's a good idea. I'll explore that option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants