Add ability to pack objects rather than just files #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows compilePack() src argument to not just be a directory with files to pack, but an Iterable that returns the objects to pack. Then it can be used to create packs that are dynamically created. PF2e Workbench can use this for a compendium of macros it creates, where the macros don't exist as directory of json files. The macro Items are created dynamically. Currently, it uses an old NeDB format compendium for these and makes the database "manually" by concatenating lines of json text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows compilePack() src argument to not just be a directory with files to pack, but an Iterable of objects to pack.
Then it can be used to create packs that are dynamically created.
PF2e Workbench can use this for a compendium of macros it creates, where the macros don't exist as directory of json files. The macro Items are created dynamically. Currently, it uses an old NeDB format compendium for these and makes the database "manually" by concatenating lines of json text.