Migrate disrupting/greaterDisrupting rune slugs to vitalizing/greaterVitalizing#21660
Open
simon-opensource wants to merge 1 commit intofoundryvtt:v13-devfrom
Open
Migrate disrupting/greaterDisrupting rune slugs to vitalizing/greaterVitalizing#21660simon-opensource wants to merge 1 commit intofoundryvtt:v13-devfrom
simon-opensource wants to merge 1 commit intofoundryvtt:v13-devfrom
Conversation
…Vitalizing The Remaster renamed the Disrupting property rune to Vitalizing, but the internal slugs were never updated. This renames all slug references and adds a migration for existing world data. Closes foundryvtt#20353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the legacy
disruptingandgreaterDisruptingproperty rune slugs tovitalizingandgreaterVitalizingto match their Remaster names. Updates rune definitions, weapon property rune types, localization keys, and all compendium pack references. Adds migration 956 to rename the slugs in existing world data.Closes #20353
Note: #15543 attempted a similar change in 2024 but was data-only with no migration. This PR includes the migration that was called out as needed in #11799 and #20353.
Migration testing
Tested locally in Foundry VTT v13.351 with 7 weapons covering varied cases:
["disrupting"]["vitalizing"]["greaterDisrupting"]["greaterVitalizing"]["flaming", "disrupting", "keen"]["flaming", "vitalizing", "keen"]["disrupting", "greaterDisrupting"]["vitalizing", "greaterVitalizing"]["flaming"]["flaming"][][]["disrupting"], specific:["disrupting"]["vitalizing"], specific:["vitalizing"]