Skip to content

Conversation

@wy-chung
Copy link
Contributor

This is a variant of g_new_providerf. This function accepts a regular string instead of a format string as its input parameter. It can save the time wasted on unnecessary format string processing.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

Thank you for taking the time to contribute to FreeBSD!
There is an issue that needs to be fixed:

  • Missing Signed-off-by lines8b11286

Please review CONTRIBUTING.md, then update and push your branch again.

Copy link
Member

@bsdjhb bsdjhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the g_new_geom review, I would just have g_new_providerf() call g_new_provider() directly. Also, I would suggest splitting this into two commits and include a manpage update.

This is a variant of g_new_providerf. This function accepts a regular string
instead of a format string as its input parameter. It can save the time
wasted on unnecessary format string processing.
@wy-chung wy-chung force-pushed the wyc/g_new_provider branch from 0f5f3b8 to 8b11286 Compare July 26, 2025 15:48
Copy link
Member

@bsdjhb bsdjhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants