libcasper: explicit cast in cap_fileargs header #1857
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implicit cast is incompatible with standard compiler options in a C++ project, making the library difficult to use. Signed-off-by: Quentin Thébault <[email protected]> Sponsored by: Defenso MFC after: 3 days Discussed with: kevans
VexedUXR
approved these changes
Oct 9, 2025
emaste
approved these changes
Oct 9, 2025
|
Looks good, @VexedUXR do you want to push it to main? I can otherwise |
You can push it :) |
freebsd-git
pushed a commit
that referenced
this pull request
Oct 9, 2025
The implicit cast is incompatible with standard compiler options in a C++ project, making the library difficult to use. Signed-off-by: Quentin Thébault <[email protected]> Sponsored by: Defenso MFC after: 3 days Discussed with: kevans Reviewed by: emaste, vexeduxr Pull request: #1857
freebsd-git
pushed a commit
that referenced
this pull request
Oct 12, 2025
The implicit cast is incompatible with standard compiler options in a C++ project, making the library difficult to use. Signed-off-by: Quentin Thébault <[email protected]> Sponsored by: Defenso MFC after: 3 days Discussed with: kevans Reviewed by: emaste, vexeduxr Pull request: #1857 (cherry picked from commit 349da4d)
freebsd-git
pushed a commit
that referenced
this pull request
Oct 12, 2025
The implicit cast is incompatible with standard compiler options in a C++ project, making the library difficult to use. Signed-off-by: Quentin Thébault <[email protected]> Sponsored by: Defenso MFC after: 3 days Discussed with: kevans Reviewed by: emaste, vexeduxr Pull request: #1857 (cherry picked from commit 349da4d) (cherry picked from commit 998dd4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicit cast is incompatible with standard compiler options in a C++ project, making the library difficult to use.
The explicit cast is already the workaround in
libcasper.h:freebsd-src/lib/libcasper/libcasper/libcasper.h
Lines 106 to 108 in 7e8fb77
Discussed with @kevans91