-
-
Notifications
You must be signed in to change notification settings - Fork 182
feat(help): apply updated design to Bulk Data page #5853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(help): apply updated design to Bulk Data page #5853
Conversation
Applied the new visual design to the Bulk Data page (`v2_bulk-data.html`) This update ensures consistent layout and styling with other API help pages, following the latest design system. Refs: freelawproject#5353
Adds an attention-grabbing comment to the old version of the template.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! New design is visible when the flag is active and looks pretty nice overall, I just left a couple of suggestions in the code.
|
||
<c-layout-with-navigation.section id="formats"> | ||
<h2>Data Format and Field Definitions</h2> | ||
<p>Files are generated using the PostgreSQL <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html"><code>COPY TO</code></a> command. This generates CSV files that correspond with the tables in our database. Files are provided using the CSV output format, in the UTF-8 encoding, with a header row on the top. If you are using PostgreSQL, the easiest way to import these files is to use the <code>COPY FROM</code> command. Details about the CSVs we generate can be found in the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">COPY documentation</a> or by reading <a class="underline" href="https://github.com/freelawproject/courtlistener/blob/main/scripts/make_bulk_data.sh">the code we use to generate these files</a>. You can import the data using <code>COPY FROM</code> by executing a sql statement like this:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link isn't super noticeable:
I think we can make it easier to spot by extending the anchor tag a little bit:
<p>Files are generated using the PostgreSQL <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html"><code>COPY TO</code></a> command. This generates CSV files that correspond with the tables in our database. Files are provided using the CSV output format, in the UTF-8 encoding, with a header row on the top. If you are using PostgreSQL, the easiest way to import these files is to use the <code>COPY FROM</code> command. Details about the CSVs we generate can be found in the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">COPY documentation</a> or by reading <a class="underline" href="https://github.com/freelawproject/courtlistener/blob/main/scripts/make_bulk_data.sh">the code we use to generate these files</a>. You can import the data using <code>COPY FROM</code> by executing a sql statement like this:</p> | |
<p>Files are generated using the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">PostgreSQL <code>COPY TO</code> command</a>. This generates CSV files that correspond with the tables in our database. Files are provided using the CSV output format, in the UTF-8 encoding, with a header row on the top. If you are using PostgreSQL, the easiest way to import these files is to use the <code>COPY FROM</code> command. Details about the CSVs we generate can be found in the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">COPY documentation</a> or by reading <a class="underline" href="https://github.com/freelawproject/courtlistener/blob/main/scripts/make_bulk_data.sh">the code we use to generate these files</a>. You can import the data using <code>COPY FROM</code> by executing a sql statement like this:</p> |
|
||
<c-layout-with-navigation.section id="formats"> | ||
<h2>Data Format and Field Definitions</h2> | ||
<p>Files are generated using the PostgreSQL <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html"><code>COPY TO</code></a> command. This generates CSV files that correspond with the tables in our database. Files are provided using the CSV output format, in the UTF-8 encoding, with a header row on the top. If you are using PostgreSQL, the easiest way to import these files is to use the <code>COPY FROM</code> command. Details about the CSVs we generate can be found in the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">COPY documentation</a> or by reading <a class="underline" href="https://github.com/freelawproject/courtlistener/blob/main/scripts/make_bulk_data.sh">the code we use to generate these files</a>. You can import the data using <code>COPY FROM</code> by executing a sql statement like this:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details about the CSVs we generate can be found in the COPY documentation
This is the same as the live version, but I wonder if the link/wording is correct here. @mlissner do we really want to direct people to the PostgreSQL docs for details about the CSVs we generate? That doesn't sound right to me, but I may be missing something 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we don't provide the highest level of service for these files. It's OK for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we'll leave it at that for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I still suggest we simply remove that link, it's confusing and we already link to the same docs in a much clearer way at the beginning of the same paragraph.
I think this works much better:
<p>Files are generated using the PostgreSQL <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html"><code>COPY TO</code></a> command. This generates CSV files that correspond with the tables in our database. Files are provided using the CSV output format, in the UTF-8 encoding, with a header row on the top. If you are using PostgreSQL, the easiest way to import these files is to use the <code>COPY FROM</code> command. Details about the CSVs we generate can be found in the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">COPY documentation</a> or by reading <a class="underline" href="https://github.com/freelawproject/courtlistener/blob/main/scripts/make_bulk_data.sh">the code we use to generate these files</a>. You can import the data using <code>COPY FROM</code> by executing a sql statement like this:</p> | |
<p>Files are generated using the <a class="underline" href="https://www.postgresql.org/docs/current/sql-copy.html">PostgreSQL <code>COPY TO</code> command</a>. This generates CSV files that correspond with the tables in our database. Files are provided using the CSV output format, in the UTF-8 encoding, with a header row on the top. If you are using PostgreSQL, the easiest way to import these files is to use the <code>COPY FROM</code> command. Details about the CSVs we generate can be found in <a class="underline" href="https://github.com/freelawproject/courtlistener/blob/main/scripts/make_bulk_data.sh">the code we use to generate these files</a>.</p> | |
<p>You can import the data using <code>COPY FROM</code> by executing a sql statement like this:</p> |
<p><strong>2024-08-02</strong>: Add new fields to the bulk data files for the Docket object: federal_dn_case_type, federal_dn_office_code, federal_dn_judge_initials_assigned, federal_dn_judge_initials_referred, federal_defendant_number, parent_docket_id.</p> | ||
<p><strong>2023-09-26</strong>: Bulk script refactored to make it easier to maintain. Courthouse table added to bulk script. Court appeals_to through table added to bulk script. Bulk script now automatically generates a shell script to load bulk data and stream the script to S3.</p> | ||
<p><strong>2023-07-07</strong>: We added the <code>FORCE_QUOTE *</code> option to our export script so that null can be distinguished from blank values. In the past, both appeared in the CSVs as commas with nothing between them (<code>,,</code>). With this change, blanks will use quotes: (<code>,"",</code>), while nulls will remain as before. This should make the <code>COPY TO</code> commands work better. In addition, several missing columns are added to the bulk data to align our exports more closely with our database.</p> | ||
<p>This is the third version of our bulk data system. Previous versions were available by jurisdiction, by day, month, or year, and in JSON format corresponding to our REST API. We also previously provided our CiteGeist data file. Each of these features has been removed in an effort to simply the feature. For more information, see <a class="underline" href="https://github.com/freelawproject/courtlistener/issues/285">here (removing day/month/year files)</a> and <a class="underline" href="https://github.com/freelawproject/courtlistener/issues/1983">here (removing the JSON format and switching to PostgreSQL dumps)</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility, links should be descriptive enough as standalone elements, so what do you say we change the text here?
<p>This is the third version of our bulk data system. Previous versions were available by jurisdiction, by day, month, or year, and in JSON format corresponding to our REST API. We also previously provided our CiteGeist data file. Each of these features has been removed in an effort to simply the feature. For more information, see <a class="underline" href="https://github.com/freelawproject/courtlistener/issues/285">here (removing day/month/year files)</a> and <a class="underline" href="https://github.com/freelawproject/courtlistener/issues/1983">here (removing the JSON format and switching to PostgreSQL dumps)</a>.</p> | |
<p>This is the third version of our bulk data system. Previous versions were available by jurisdiction, by day, month, or year, and in JSON format corresponding to our REST API. We also previously provided our CiteGeist data file. Each of these features has been removed in an effort to simply the feature. For more information, please refer to <a class="underline" href="https://github.com/freelawproject/courtlistener/issues/285">GitHub issue #285 (removing day/month/year files)</a> and <a class="underline" href="https://github.com/freelawproject/courtlistener/issues/1983">GitHub issue #1983 (removing JSON format and switching to PostgreSQL dumps)</a>.</p> |
How does that sound @mlissner ?
Before:

After:

Applied the new visual design to the Bulk Data page (
v2_bulk-data.html
)This update ensures consistent layout and styling with other API help pages, following the latest design system.
Screenshot of updated design:
Refs: #5353