-
-
Notifications
You must be signed in to change notification settings - Fork 182
Add deployment options #5958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mlissner
wants to merge
9
commits into
main
Choose a base branch
from
issue-5868-streamline-deployments-2025-07-13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−2
Open
Add deployment options #5958
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b1c4612
feat(ci): Add support for partial CI
mlissner b7b6b34
feat(github): Adds PR template
mlissner 5f32e72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 51e8758
fix(github): Tweak the PR template
mlissner b1813a3
Merge remote-tracking branch 'origin/issue-5868-streamline-deployment…
mlissner f6efaa4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a0b186a
fix(ci): Also skip build on cronjob
mlissner 2002b87
fix(gh): Tweak PR template
mlissner ad26eaf
fix(ci): Remove unused output var
mlissner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
## Fixes | ||
|
||
What bugs does this fix? Use the syntax to auto-close the issue: | ||
|
||
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword | ||
|
||
E.g.: "Fixes: #XYZ" | ||
|
||
|
||
## Summary | ||
|
||
What does this fix, how did you fix it, what approach did you take, what gotchas are there in your code or compromises did you make? | ||
|
||
|
||
## Deployment | ||
|
||
<details> | ||
<summary>Instructions</summary> | ||
|
||
--- | ||
|
||
The following labels control the deployment of this PR if they’re applied. Please choose which should be applied, then apply them to this PR: | ||
|
||
| Label | Description | Use case | | ||
| --------------------- | --------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------- | | ||
| `skip-deploy` | The entire deployment can be skipped. | This might be the case for a small fix, a tweak to documentation or something like that. | | ||
| `skip-web-deploy` | The web tier can be skipped. | This is the case if you're working on code that doesn't affect the front end, like management commands, tasks, or documentation. | | ||
| `skip-celery-deploy` | Deployment to celery can be skipped. | This is the case if you make no changes to tasks.py or the code that tasks rely on. | | ||
| `skip-cronjob-deploy` | Deployment to cron jobs can be skipped. | This is the case if no changes are made that affect cronjobs. | | ||
|
||
**If deployment is required:** | ||
|
||
- What extra steps are needed to deploy this beyond the standard deploy? | ||
- Do scripts need to be run or things like that? | ||
- If this is more than a quick thing, a new issue should be created in our infra repo: https://github.com/freelawproject/infrastructure/issues/new (if you don’t have access to it, just put the steps here) | ||
|
||
--- | ||
|
||
</details> | ||
|
||
**This PR should:** | ||
|
||
- [ ] <code>skip-deploy</code> | ||
- [ ] <code>skip-web-deploy</code> | ||
- [ ] <code>skip-celery-deploy</code> | ||
- [ ] <code>skip-cronjob-deploy</code> | ||
|
||
Extra steps to deploy this PR: | ||
1. Run script.... | ||
|
||
|
||
## Screenshots | ||
|
||
If this changes the front end, please include desktop and mobile screenshots or videos showing the new feature. | ||
|
||
<details> | ||
<summary>Desktop</summary> | ||
|
||
YOUR IMAGE(S) HERE | ||
|
||
</details> | ||
|
||
|
||
<details> | ||
<summary>Mobile</summary> | ||
|
||
YOUR IMAGE(S) HERE | ||
|
||
</details> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this skip the image build and push if any of the skip labels is applied?
Is that correct? For instance, if the author adds the
skip-web-deploy
label, we’d still need the image to be built and pushed so that the Celery and cronjob deployments receive the changes, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if any of these labels are applied, it won't run this step, and I'm pretty sure that means the deploy won't run since it
needs
thebuild
step. I'm not positive, but I think that's how it will work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that block of code means that if any
skip-
label is present, the build process is skipped, which is my concern.For example, if the user only passes
skip-celery-deploy
, it should still deploy to the web service and the cron job, right? But because there’s no build, the deploy action is completely omitted?Shouldn’t we only skip the
build
step when the entire deploy is skipped with skip-deploy?