Skip to content

Fix RecursionError test #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Fix RecursionError test #6003

merged 1 commit into from
Jul 17, 2025

Conversation

quevon24
Copy link
Member

@quevon24 quevon24 commented Jul 17, 2025

This is a small change in one of the tests to ensure the correct order of the opinion_ids when retrying in find_citations_and_parentheticals_for_opinion_by_pks function.

Also it fixes an incorrect indentation in one of the tests related to recursion and operational error.

I got this in one of my draft PRs:

AssertionError: Tuples differ: ([44, 42], False, False) != ([42, 44], False, False)

First differing element 0:
[44, 42]
[42, 44]

@quevon24 quevon24 marked this pull request as ready for review July 17, 2025 21:33
@quevon24 quevon24 requested a review from grossir July 17, 2025 21:36
Copy link
Contributor

@grossir grossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think the test wasn't erroring because the standalone function (not inside a class, without indentantion) was not actually being included in the test suite. Indeed, you won't find the test name in the logs for the previous PR

@grossir grossir merged commit 6b5528f into main Jul 17, 2025
9 checks passed
@grossir grossir deleted the fix-recursion-test-error branch July 17, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants